refactor(ui): unify sidebar nav/list-row rhythm — shared tokens, 13px muted group headers (#546 PR7) - #652
Merged
Merged
Conversation
… muted group headers (#546 PR7) - nav row cva: Tailwind alpha (bg-foreground/6, /9) → CSS variable tokens (--state-hover-bg, --state-selected-bg, --h-control-lg), shared with list-row - nav row inset: width:calc(100%-12px)+margin → parent .maka-sidebar-modules padding (var(--space-2)), aligned with .maka-list-stackContent - group headers: three variants (list-group-label / list-group-toggle / list-project-heading) unified to font-size-ui + muted-foreground + medium; distinguished from session rows by color not size - drag-strip: magic number 8px → var(--maka-sidebar-topbar-gap)
…dex P2) UiButton size=nav contributes no height; removing min-height collapsed the clickable project header below the 32px control tier. Keep min-height: var(--h-control-lg); the muted-foreground color still distinguishes it from session rows.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
统一 sidebar 的 nav row 和 list-row 视觉节奏。nav row 视觉从 Tailwind alpha 值统一到 CSS variable token,和 list-row 共用 hover/active/height;三种 group header 统一成 13px + muted-foreground + medium,靠颜色区分层级而非字号;nav row 内缩从 calc(100%-12px)+margin 改成父容器 padding 对齐 list。
Why
#546 Phase B PR7。nav row(cvA)和 list-row(CSS)是两套样式系统,hover/active 深度不同(nav 6%/9% vs list 4%/6.5%),三种 group header 字号/高度/颜色各异,项目标题和会话项同高同大分不清层级。统一后同一面里的行节奏一致,改 token 值两边同步。
Refs #546
Scope
Changed:
packages/ui/src/session-sidebar-nav.tsx: navRowVariants + settingsButtonClass 的 Tailwind alpha 值(bg-foreground/6, /9)改成 CSS variable token(--state-hover-bg, --state-selected-bg, --h-control-lg),和 list-row 共用apps/desktop/src/renderer/styles/sidebar.css:Not included:
Verification
npm run build全绿npm --workspace @maka/ui test: 46 pass, 0 failnpm --workspace @maka/desktop run test:checks: console/a11y/copy 全 OKUser-facing impact
sidebar 视觉变化:
Reviewer notes
Checklist