Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX support for _split_v2 - #20250

Merged
Zha0q1 merged 4 commits into
apache:v1.xfrom
waytrue17:split_v2
May 6, 2021
Merged

[v1.x] ONNX support for _split_v2#20250
Zha0q1 merged 4 commits into
apache:v1.xfrom
waytrue17:split_v2

Conversation

@waytrue17

@waytrue17 waytrue17 commented May 6, 2021

Copy link
Copy Markdown
Contributor

Description

ONNX support and unittest for _split_v2

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@waytrue17
waytrue17 requested a review from szha as a code owner May 6, 2021 01:48
@mxnet-bot

mxnet-bot commented May 6, 2021

Copy link
Copy Markdown

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, miscellaneous, unix-gpu, edge, centos-cpu, unix-cpu, centos-gpu, windows-cpu, website, windows-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label May 6, 2021
Zha0q1
Zha0q1 reviewed May 6, 2021
View reviewed changes

@Zha0q1 Zha0q1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick implementation! left a few minor comments

Comment thread python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py Outdated
Comment thread tests/python-pytest/onnx/test_operators.py
op_export_test('sample_multinomial', M, [x], tmp_path, mx_map=rand_check_nd, onnx_map=rand_check)


@pytest.mark.parametrize("dtype", ['float32', 'int32', 'int64'])

@Zha0q1 Zha0q1 May 6, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the customer use case covered by the unit tests?

@waytrue17 waytrue17 May 6, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customer has not shared their use case yet

Comment thread python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py Outdated
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 6, 2021
josephevans
josephevans approved these changes May 6, 2021
View reviewed changes

@josephevans josephevans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 6, 2021
@Zha0q1
Zha0q1 merged commit e329e84 into apache:v1.x May 6, 2021
@waytrue17
waytrue17 deleted the split_v2 branch May 28, 2021 00:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner
2 more reviewers
@Zha0q1 Zha0q1 Zha0q1 left review comments
@josephevans josephevans josephevans approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@waytrue17 @mxnet-bot @josephevans @Zha0q1 @mseth10