Skip to content

[fix][broker] fix flaky test in SystemTopicBasedTopicPoliciesServiceTest - #25098

Merged
lhotari merged 3 commits into
apache:masterfrom
TakaHiR07:fix_for_flaky_test
Jan 2, 2026
Merged

[fix][broker] fix flaky test in SystemTopicBasedTopicPoliciesServiceTest#25098
lhotari merged 3 commits into
apache:masterfrom
TakaHiR07:fix_for_flaky_test

Conversation

@TakaHiR07

Copy link
Copy Markdown
Contributor

Main Issue: #25081

Motivation

fix for flaky test.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Dec 19, 2025

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.42%. Comparing base (df89b60) to head (6a15d2c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #25098    +/-   ##
==========================================
  Coverage     74.42%   74.42%            
+ Complexity    34053    33658   -395     
==========================================
  Files          1899     1899            
  Lines        149659   149659            
  Branches      17394    17394            
==========================================
+ Hits         111389   111391     +2     
+ Misses        29396    29392     -4     
- Partials       8874     8876     +2     
Flag Coverage Δ
inttests 26.69% <ø> (?)
systests 23.00% <ø> (-0.05%) ⬇️
unittests 73.96% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari
lhotari merged commit 3e6133e into apache:master Jan 2, 2026
99 of 103 checks passed
lhotari added a commit that referenced this pull request Apr 21, 2026
…est (#25098)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 3e6133e)
lhotari added a commit that referenced this pull request Apr 21, 2026
…est (#25098)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 3e6133e)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2026
…est (apache#25098)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 3e6133e)
(cherry picked from commit bcf5ec1)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 27, 2026
…est (apache#25098)

Co-authored-by: fanjianye <fanjianye@bigo.sg>
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 3e6133e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants