Skip to content

[improve][cli] Add client side looping in "pulsar-admin topics analyze-backlog" cli to avoid potential HTTP call timeout - #25126

Merged
lhotari merged 22 commits into
apache:masterfrom
oneby-wang:pulsar_cli_client_side_analyze_backlog
Apr 27, 2026
Merged

[improve][cli] Add client side looping in "pulsar-admin topics analyze-backlog" cli to avoid potential HTTP call timeout#25126
lhotari merged 22 commits into
apache:masterfrom
oneby-wang:pulsar_cli_client_side_analyze_backlog

Conversation

@oneby-wang

@oneby-wang oneby-wang commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #25537

Motivation

Use client-side looping instead of increasing broker settings to avoid potential HTTP call timeout in "pulsar-admin topics analyze-backlog" cli.

Modifications

Add client-side looping, add test.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: oneby-wang#21

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 6, 2026
lhotari
lhotari reviewed Jan 20, 2026
View reviewed changes
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
Comment thread pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java Outdated
@oneby-wang oneby-wang mentioned this pull request Jan 21, 2026
Merged
15 tasks
@oneby-wang

oneby-wang commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@lhotari Could help me solve the above questions when you have a moment? Especially about how to write integration tests easily in admin CLI module.

I'll refactor this PR using the API that PR #25127 provided once I'm back.

@lhotari

lhotari commented Feb 6, 2026

Copy link
Copy Markdown
Member

@oneby-wang #25127 has been merged

@oneby-wang
oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch from b48e0eb to 83bdbf1 Compare February 6, 2026 11:56
lhotari
lhotari reviewed Feb 6, 2026
View reviewed changes
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
@oneby-wang
oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch 3 times, most recently from 425e8bf to 941b50c Compare February 25, 2026 14:05
@oneby-wang
oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch from 717742a to 91001d3 Compare March 28, 2026 03:58
@oneby-wang
oneby-wang force-pushed the pulsar_cli_client_side_analyze_backlog branch from 91001d3 to 2456a05 Compare April 4, 2026 12:00
@oneby-wang
oneby-wang requested a review from lhotari April 6, 2026 05:03
@oneby-wang

oneby-wang commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Hi @lhotari, could you please help review this refactored PR?

@oneby-wang oneby-wang mentioned this pull request Apr 16, 2026
Closed
2 tasks
lhotari
lhotari reviewed Apr 21, 2026
View reviewed changes
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
lhotari
lhotari reviewed Apr 21, 2026
View reviewed changes
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
lhotari
lhotari reviewed Apr 21, 2026
View reviewed changes
Comment thread pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java Outdated
lhotari
lhotari reviewed Apr 21, 2026
View reviewed changes

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments

lhotari
lhotari approved these changes Apr 27, 2026
View reviewed changes

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.3.0 milestone Apr 27, 2026
@lhotari

lhotari commented Apr 27, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution @oneby-wang

@lhotari
lhotari merged commit 13e1fac into apache:master Apr 27, 2026
43 checks passed
poorbarcode pushed a commit to poorbarcode/pulsar that referenced this pull request May 6, 2026
@oneby-wang @poorbarcode
[improve][cli] Add client side looping in "pulsar-admin topics analyz…
c0c2936 
…e-backlog" cli to avoid potential HTTP call timeout (apache#25126)
Technoboy- pushed a commit that referenced this pull request May 11, 2026
@oneby-wang @Technoboy-
[improve][cli] Add client side looping in "pulsar-admin topics analyz…
44cc013 
…e-backlog" cli to avoid potential HTTP call timeout (#25126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

@oneby-wang oneby-wang

Labels

cherry-picked/branch-4.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/4.1.4 release/4.2.2

Projects

None yet

Milestone

5.0.0-M1

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add client side looping to "pulsar-admin topics analyze-backlog" cli command

3 participants

@oneby-wang @lhotari @Technoboy-