[improve][broker] Migrate remaining broker proto files from protobuf to LightProto - #25337
Merged
Merged
Conversation
…to LightProto Migrate SchemaStorageFormat, SchemaRegistryFormat, and DelayedMessageIndexBucketMetadata proto files to use LightProto generated code instead of standard protobuf. - Add 3 proto files to lightproto-maven-plugin, remove protobuf compile goal - Replace Builder patterns with direct mutable object construction - Replace ByteString with byte[] for bytes fields - Use indexed loops for repeated field iteration - Use instance-based parseFrom instead of static parseFrom - Use forEachDelayedIndexBitMap for map field iteration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #25337 +/- ##
=============================================
+ Coverage 37.37% 72.75% +35.37%
- Complexity 13188 33868 +20680
=============================================
Files 1897 1954 +57
Lines 150557 154762 +4205
Branches 17215 17721 +506
=============================================
+ Hits 56276 112595 +56319
+ Misses 86612 33135 -53477
- Partials 7669 9032 +1363
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lhotari
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compilegoal (keeping onlytest-compilefor test-only proto files)Test plan
mvn compile -pl pulsar-brokerpassesmvn test-compile -pl pulsar-brokerpassesBookkeeperBucketSnapshotStorageTestSchemaTestDocumentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Your PR doesn't need any doc update)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)