[fix][test] Extend SameAuthParamsLookupAutoClusterFailoverTest phase timeouts - #25563
Merged
Merged
Conversation
…timeouts The integration test drives three state-convergence phases (failover 0->2, recover 2->1, recover 1->0) each bounded by Awaitility.atMost(60s). The probe timeout is 3 seconds and recoverThreshold is 5, so one slow/failing probe per iteration can stretch a single phase close to 30 seconds; on slow CI agents that cumulative variance pushes the 1->0 phase past 60 seconds and the test fails with ConditionTimeoutException. Raise each phase to 120 seconds and raise the overall test timeout from 240s to 480s so the per-phase budgets still fit.
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
…timeouts (apache#25563) (cherry picked from commit 43c7ad8) (cherry picked from commit 8294e3e)
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
May 6, 2026
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…timeouts (apache#25563) (cherry picked from commit 43c7ad8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SameAuthParamsLookupAutoClusterFailoverTest.testAutoClusterFailoverdrives three state-convergence phases — failover 0->2, recover 2->1, recover 1->0 — each bounded byAwaitility.await().atMost(60, SECONDS). The probe timeout insideSameAuthParamsLookupAutoClusterFailoveris 3 seconds andrecoverThresholdis 5, so a single slow or failing probe per iteration can stretch one phase close to 30 seconds. On slow CI agents the cumulative variance pushes the final phase past 60 seconds and the test fails withConditionTimeoutException.Example failure
Modifications
Awaitility.atMostfrom 60s to 120s so a single phase can still complete even when every check cycle is stretched by slow probes.timeOutfrom 240s to 480s so the three per-phase budgets still fit comfortably along with setup and teardown.Verifying this change
This change is already covered by existing tests, specifically
SameAuthParamsLookupAutoClusterFailoverTest.testAutoClusterFailover.Does this pull request potentially affect one of the following parts: