[fix][broker] Merge broker offload extra configurations - #25736
Merged
nodece merged 1 commit intoMay 12, 2026
Conversation
lhotari
approved these changes
May 11, 2026
coderzc
changed the title
dao-jun
approved these changes
May 11, 2026
coderzc
added
type/bug
Technoboy-
pushed a commit
that referenced
this pull request
May 12, 2026
coderzc
added a commit
that referenced
this pull request
May 13, 2026
(cherry picked from commit bb52957)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
(cherry picked from commit bb52957)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OffloadPoliciesImpl.create(Properties)recognizes broker config entries with themanagedLedgerOffloadExtraConfigprefix and stores them inmanagedLedgerExtraConfigurations.However,
OffloadPoliciesImpl.mergeConfiguration(...)did not apply the same parsing when broker properties were used as the fallback layer. As a result, applied offload policies could omit broker-level extra offloader configuration.Modifications
managedLedgerOffloadExtraConfig*entries fromProperties.mergeConfiguration(...)formanagedLedgerExtraConfigurations.Verifying this change
./gradlew :pulsar-common:test --tests org.apache.pulsar.common.policies.data.OffloadPoliciesTest