[improve][fn] make built-in functions reload incremental - #25868
Merged
lhotari merged 3 commits intoJun 2, 2026
Conversation
Contributor
Author
pratt4
changed the title
lhotari
changed the title
Member
|
I renamed the title of this PR. It's better not to reference issues in the PR title, but instead describe in imperative form what the PR does (there's a similar best practice for commit messages). |
Dream95
approved these changes
Jun 2, 2026
lhotari
approved these changes
Jun 2, 2026
lhotari
pushed a commit
that referenced
this pull request
Jun 3, 2026
(cherry picked from commit d57af8f)
lhotari
pushed a commit
that referenced
this pull request
Jun 3, 2026
(cherry picked from commit d57af8f)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
(cherry picked from commit d57af8f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25791.
FunctionsManager.reloadFunctions()used to recreate every built-in function archive on reload, then close all previousFunctionArchiveinstances. That meant unchanged NARs were still reopened and their existing classloader/package state was discarded.This mirrors the incremental reload behavior recently added for connectors.
Changes
FunctionArchiveFunctionUtils.reloadFunctions()FunctionArchiveinstances when the archive path and MD5 are unchangedFunctionsManager.reloadFunctions()to use the incremental reload result