[improve][client] Clean up unacked message tracker when topics are removed in multi-topic consumers - #25923
Merged
lhotari merged 1 commit intoJun 5, 2026
Conversation
…n multi-topic consumers Signed-off-by: Dream95 <zhou_8621@163.com>
lhotari
approved these changes
Jun 5, 2026
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 8, 2026
…moved in multi-topic consumers (apache#25923) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 26cf550) (cherry picked from commit 8ead3bd)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 9, 2026
…moved in multi-topic consumers (apache#25923) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 26cf550) (cherry picked from commit 8ead3bd)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
…moved in multi-topic consumers (apache#25923) Signed-off-by: Dream95 <zhou_8621@163.com> (cherry picked from commit 26cf550)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to [#25921]. That PR fixed incorrect unacked-message removal on explicit unsubscribe by comparing base partitioned topic names instead of substring matching. This change extends the same cleanup to other paths where a multi-topic or pattern consumer drops a topic without calling unsubscribe, so timed-out unacked entries are not left behind.
In production, topics can also disappear from a consumer when:
Those paths closed partition consumers but did not clear matching entries from the unacked tracker.
Modifications
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Matching PR in forked repository
PR in forked repository: Dream95#13