[fix][broker] Fail fast for load balancer misconfigurations instead of falling back to SimpleLoadManagerImpl - #26031
Merged
lhotari merged 1 commit intoJun 15, 2026
Conversation
BewareMyPower
added
release/4.2.3
release/4.0.12
type/bug
BewareMyPower
requested review from
codelipenghui,
hangc0276,
lhotari,
merlimat,
nodece and
shibd
June 15, 2026 09:52
BewareMyPower
changed the title
nodece
approved these changes
Jun 15, 2026
Member
|
@BewareMyPower This fix should only be released in 5.0. Otherwise, I'm worried that Pulsar may fail to work when users provide an incorrect configuration. |
BewareMyPower
deleted the
bewaremypower/fail-fast-load-balancer-incorrect-config
branch
June 15, 2026 13:01
Contributor
Author
|
@nodece Falling back to |
Member
@nodece I think that with k8s clusters, with proper poddistruptionbudget config (or similar), the broker sts rollout would stop if a broker doesn't come up after upgrading. The user could dig into logs if that happens and prevents an upgrade. |
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…f falling back to SimpleLoadManagerImpl (apache#26031) (cherry picked from commit c3f8c05)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
…f falling back to SimpleLoadManagerImpl (apache#26031) (cherry picked from commit c3f8c05)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We observed production issues due to the following misconfigurations:
Logs:
This did not fail fast, instead, it created a
SimpleLoadManagerImplobject as a load balance. This early implementation has many issues and its functionality is hardly tested, for example, it might not work well with multiple listeners specified likethe broker do not have gw listener.IMO, we should remove this outdated implementation in future, but for now, I think we should fail fast for misconfigurations rather than falling back to this implementation.