[fix][meta] Fix RocksdbMetadataStore instanceId not advancing across restarts - #26218
Merged
lhotari merged 1 commit intoJul 25, 2026
Merged
Conversation
lhotari
approved these changes
Jul 23, 2026
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…restarts (apache#26218) Co-authored-by: maxlisongsong <maxlisongsong@didiglobal.com> (cherry picked from commit a4b7aaa)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…restarts (apache#26218) Co-authored-by: maxlisongsong <maxlisongsong@didiglobal.com> (cherry picked from commit a4b7aaa)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…restarts (apache#26218) Co-authored-by: maxlisongsong <maxlisongsong@didiglobal.com> (cherry picked from commit a4b7aaa)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
…restarts (apache#26218) Co-authored-by: maxlisongsong <maxlisongsong@didiglobal.com> (cherry picked from commit a4b7aaa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RocksdbMetadataStore#loadSequentialIdGeneratoris supposed to persistthe initial value of the sequential-id counter to
SEQUENTIAL_ID_KEYwhen no such record exists yet in RocksDB. Instead, it wrote that value
to
INSTANCE_ID_KEYby mistake.Since the constructor calls
loadSequentialIdGenerator()beforeloadInstanceId(), this bug clobbersINSTANCE_ID_KEYto0rightbefore
loadInstanceId()reads it back — soinstanceIdis alwayscomputed as
0 + 1 = 1on startup, instead of advancing (0,1,2, ...) across restarts, whenever no sequential node has ever beencreated in that store.
instanceIdis used to tag ownership of ephemeral nodes(
metaValue.owner == instanceId), so a store stuck on the sameinstanceIdacross restarts loses the ability to distinguish thecurrent process instance from a previous one for ephemeral-node
ownership checks.
Modifications
RocksdbMetadataStore#loadSequentialIdGenerator, write theinitial counter value to
SEQUENTIAL_ID_KEYinstead ofINSTANCE_ID_KEY.Verifying this change
This change is already covered by existing tests, such as
RocksdbMetadataStoreTest#testMultipleInstancesandRocksdbMetadataStoreTest#testOpenDbWithConfigFile, which exercisestore open/close/reopen cycles.
Does this pull request potentially affect one of the following parts: