[fix][ml] Preserve ledger properties when closing ledger - #26227
Merged
Conversation
nodece
approved these changes
Jul 23, 2026
11 tasks
Member
|
PIP-404 doesn't exist on branch-4.0 |
lhotari
pushed a commit
that referenced
this pull request
Jul 25, 2026
(cherry picked from commit 79a2c6f)
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a ledger is closed (either because it reaches max entries or is manually closed), the
ledgerClosed()method creates anew LedgerInfoobject with only basic fields (ledgerId, entries, size, timestamp), which discards any previously set properties.This causes a bug where ledger properties are lost after ledger closure:
asyncAddLedgerProperty(ledgerId, key, value)to set a property on the current ledgerledgerClosed()method replaces the LedgerInfo with a new instance that has no propertiesModifications
ManagedLedgerImpl.ledgerClosed()method to preserve existing ledger properties when updating the LedgerInfo on ledger close.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes