[fix][broker] Fix incorrect listener URLs returned by ModularLoadManager lookups - #26245
Merged
Merged
Conversation
void-ptr974
changed the title
lhotari
approved these changes
Jul 25, 2026
lhotari
reviewed
Jul 25, 2026
Comment on lines
474
to
478
| if (options.isAuthoritative()) { | ||
| targetMap = findingBundlesAuthoritative; | ||
| } else { | ||
| targetMap = findingBundlesNotAuthoritative; | ||
| } |
Member
There was a problem hiding this comment.
I already merged this and after merging I noticed that having 2 separate maps would no longer be necessary if authoritative would be part of the key as well.
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…ger lookups (apache#26245) (cherry picked from commit 931f9fb)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…ger lookups (apache#26245) (cherry picked from commit 931f9fb)
sandeep-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2026
…ger lookups (apache#26245) (cherry picked from commit 931f9fb)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 28, 2026
…ger lookups (apache#26245) (cherry picked from commit 931f9fb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26244
Motivation
ModularLoadManager coalesces in-flight lookup requests by namespace bundle alone. Concurrent requests for the same bundle with different advertised listener options can therefore share a
LookupResultgenerated for another request and receive the wrong broker URL. Requests with different read-only or topic-preload semantics can also be coalesced.Modifications
Verification
./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.namespace.NamespaceServiceLookupOptionsTest./gradlew :pulsar-broker:checkstyleMain :pulsar-broker:checkstyleTest