Simplify correlation of test prefix to test ID. - #2071
Merged
Conversation
- At present in the integration tests, it's difficult for humans to look at logs and correlate the test prefix value we use to keep resource names short to the test suite and method. - Use `clitests/<SuiteName>/<method>.log` for placing test log files. - Adds the test name to the log metadata.
Code Coverage
|
… work. Move logger construction ahead of scratch-dir creation so a "test start" message is the first thing recorded, and log "test end" (pass/fail) right after the test body closure returns/throws. Makes it possible to bound a test's actual execution window directly from its own log file.
Bookends the test start/end messages with a third marker once runCleanup() finishes, so a test's teardown time is visible in its own log alongside its execution window.
JaewonHur
reviewed
Aug 5, 2026
| // their concurrently-running cases, so fall back to the per-invocation `testID` to keep | ||
| // each case's log file distinct. | ||
| let isParameterized = Test.Case.current?.isParameterized ?? false | ||
| let logFileName = isParameterized ? "\(testName)-\(testID).log" : "\(testName).log" |
Contributor
There was a problem hiding this comment.
We can use Test.Case.current?.arguments to append passed argument in log file name.
JaewonHur
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.