test: cover disabling --site-per-process default (#2202) - #2218
Merged
Conversation
# why `--site-per-process` is a Stagehand local-browser default, so users need a reliable regression test that `localBrowserLaunchOptions.ignoreDefaultArgs` can remove it. Refs #2193. # what changed Added unit coverage for `launchLocalChrome` verifying that `ignoreDefaultArgs: ["--site-per-process"]` removes the Stagehand default while preserving user-provided Chromium flags such as `--disable-features=site-per-process,IsolateOrigins` and `--renderer-process-limit=6`. # test plan - `pnpm --dir packages/core exec vitest run --config vitest.esm.config.mjs dist/esm/tests/unit/launch-local-ignore-default-args.test.js` - `pnpm --filter @browserbasehq/stagehand run typecheck` - `pnpm exec prettier --check packages/core/tests/unit/launch-local-ignore-default-args.test.ts` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds a unit test to ensure `localBrowserLaunchOptions.ignoreDefaultArgs: ['--site-per-process']` disables Stagehand’s `--site-per-process` default in local Chrome while preserving user flags (`--disable-features=site-per-process,IsolateOrigins`, `--renderer-process-limit=6`, `--remote-allow-origins=*`). Refs #2193. <sup>Written for commit 8dd9cbf. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/browserbase/stagehand/pull/2202?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> Co-authored-by: cyphercodes <cyphercodes@users.noreply.github.com>
|
monadoid
approved these changes
Jun 9, 2026
felipeofdev-ai
pushed a commit
to felipeofdev-ai/stagehand
that referenced
this pull request
Aug 4, 2026
…rowserbase#2218) # why `--site-per-process` is a Stagehand local-browser default, so users need a reliable regression test that `localBrowserLaunchOptions.ignoreDefaultArgs` can remove it. Refs browserbase#2193. # what changed Added unit coverage for `launchLocalChrome` verifying that `ignoreDefaultArgs: ["--site-per-process"]` removes the Stagehand default while preserving user-provided Chromium flags such as `--disable-features=site-per-process,IsolateOrigins` and `--renderer-process-limit=6`. # test plan - `pnpm --dir packages/core exec vitest run --config vitest.esm.config.mjs dist/esm/tests/unit/launch-local-ignore-default-args.test.js` - `pnpm --filter @browserbasehq/stagehand run typecheck` - `pnpm exec prettier --check packages/core/tests/unit/launch-local-ignore-default-args.test.ts` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds a unit test to ensure `localBrowserLaunchOptions.ignoreDefaultArgs: ['--site-per-process']` disables Stagehand’s `--site-per-process` default in local Chrome while preserving user flags (`--disable-features=site-per-process,IsolateOrigins`, `--renderer-process-limit=6`, `--remote-allow-origins=*`). Refs browserbase#2193. <sup>Written for commit 8dd9cbf. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/browserbase/stagehand/pull/2202?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. --> # why # what changed # test plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
--site-per-processis a Stagehand local-browser default, so users need a reliable regression test thatlocalBrowserLaunchOptions.ignoreDefaultArgscan remove it. Refs #2193.what changed
Added unit coverage for
launchLocalChromeverifying thatignoreDefaultArgs: ["--site-per-process"]removes the Stagehand default while preserving user-provided Chromium flags such as--disable-features=site-per-process,IsolateOriginsand--renderer-process-limit=6.test plan
---pnpm --dir packages/core exec vitest run --config vitest.esm.config.mjs dist/esm/tests/unit/launch-local-ignore-default-args.test.jspnpm --filter @browserbasehq/stagehand run typecheckpnpm exec prettier --check packages/core/tests/unit/launch-local-ignore-default-args.test.tsSummary by cubic
Adds a unit test to ensure
localBrowserLaunchOptions.ignoreDefaultArgs: ['--site-per-process']disables Stagehand’s--site-per-processdefault in local Chrome while preserving user flags (--disable-features=site-per-process,IsolateOrigins,--renderer-process-limit=6,--remote-allow-origins=*). Refs #2193.Written for commit 8dd9cbf. Summary will update on new commits.
why
what changed
test plan