Skip to content

test: cover disabling --site-per-process default (#2202) - #2218

Merged
seanmcguire12 merged 1 commit into
mainfrom
evals/external-contrib-cyphercodes
Jun 9, 2026
Merged

test: cover disabling --site-per-process default (#2202)#2218
seanmcguire12 merged 1 commit into
mainfrom
evals/external-contrib-cyphercodes

Conversation

@seanmcguire12

Copy link
Copy Markdown
Member

why

--site-per-process is a Stagehand local-browser default, so users need a reliable regression test that
localBrowserLaunchOptions.ignoreDefaultArgs can remove it. Refs #2193.

what changed

Added unit coverage for launchLocalChrome verifying that ignoreDefaultArgs: ["--site-per-process"] removes the Stagehand default while preserving user-provided Chromium flags such as --disable-features=site-per-process,IsolateOrigins and --renderer-process-limit=6.

test plan

  • pnpm --dir packages/core exec vitest run --config vitest.esm.config.mjs dist/esm/tests/unit/launch-local-ignore-default-args.test.js
  • pnpm --filter @browserbasehq/stagehand run typecheck
  • pnpm exec prettier --check packages/core/tests/unit/launch-local-ignore-default-args.test.ts
---

Summary by cubic

Adds a unit test to ensure localBrowserLaunchOptions.ignoreDefaultArgs: ['--site-per-process'] disables Stagehand’s --site-per-process default in local Chrome while preserving user flags (--disable-features=site-per-process,IsolateOrigins, --renderer-process-limit=6, --remote-allow-origins=*). Refs #2193.

Written for commit 8dd9cbf. Summary will update on new commits.

Review in cubic

why

what changed

test plan

# why

`--site-per-process` is a Stagehand local-browser default, so users need
a reliable regression test that
`localBrowserLaunchOptions.ignoreDefaultArgs` can remove it. Refs #2193.

# what changed

Added unit coverage for `launchLocalChrome` verifying that
`ignoreDefaultArgs: ["--site-per-process"]` removes the Stagehand
default while preserving user-provided Chromium flags such as
`--disable-features=site-per-process,IsolateOrigins` and
`--renderer-process-limit=6`.

# test plan

- `pnpm --dir packages/core exec vitest run --config
vitest.esm.config.mjs
dist/esm/tests/unit/launch-local-ignore-default-args.test.js`
- `pnpm --filter @browserbasehq/stagehand run typecheck`
- `pnpm exec prettier --check
packages/core/tests/unit/launch-local-ignore-default-args.test.ts`

<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Adds a unit test to ensure `localBrowserLaunchOptions.ignoreDefaultArgs:
['--site-per-process']` disables Stagehand’s `--site-per-process`
default in local Chrome while preserving user flags
(`--disable-features=site-per-process,IsolateOrigins`,
`--renderer-process-limit=6`, `--remote-allow-origins=*`). Refs #2193.

<sup>Written for commit 8dd9cbf.
Summary will update on new commits.</sup>

<a
href="https://cubic.dev/pr/browserbase/stagehand/pull/2202?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>

<!-- End of auto-generated description by cubic. -->

Co-authored-by: cyphercodes <cyphercodes@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ce6744d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@seanmcguire12
seanmcguire12 merged commit 4e6f5cc into main Jun 9, 2026
223 checks passed
felipeofdev-ai pushed a commit to felipeofdev-ai/stagehand that referenced this pull request Aug 4, 2026
…rowserbase#2218)

# why

`--site-per-process` is a Stagehand local-browser default, so users need
a reliable regression test that
`localBrowserLaunchOptions.ignoreDefaultArgs` can remove it. Refs browserbase#2193.

# what changed

Added unit coverage for `launchLocalChrome` verifying that
`ignoreDefaultArgs: ["--site-per-process"]` removes the Stagehand
default while preserving user-provided Chromium flags such as
`--disable-features=site-per-process,IsolateOrigins` and
`--renderer-process-limit=6`.

# test plan

- `pnpm --dir packages/core exec vitest run --config
vitest.esm.config.mjs
dist/esm/tests/unit/launch-local-ignore-default-args.test.js`
- `pnpm --filter @browserbasehq/stagehand run typecheck`
- `pnpm exec prettier --check
packages/core/tests/unit/launch-local-ignore-default-args.test.ts`

<!-- This is an auto-generated description by cubic. --> ---
## Summary by cubic
Adds a unit test to ensure `localBrowserLaunchOptions.ignoreDefaultArgs:
['--site-per-process']` disables Stagehand’s `--site-per-process`
default in local Chrome while preserving user flags
(`--disable-features=site-per-process,IsolateOrigins`,
`--renderer-process-limit=6`, `--remote-allow-origins=*`). Refs browserbase#2193.

<sup>Written for commit 8dd9cbf.
Summary will update on new commits.</sup>

<a

href="https://cubic.dev/pr/browserbase/stagehand/pull/2202?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>

<!-- End of auto-generated description by cubic. -->

# why

# what changed

# test plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants