new config miniflare attempt 3

[emily-shen]

Config:

• cobbled together from the cloudflare config format defined in the @cloudflare/config package.
• have had to modify the imported config to add miniflare specific options and also make id's required
• have added a reconstructed (used to be assembled from each plugin options) schema of v4 miniflare options for the v4 to v5 conversion helper.

All plugins now get the full config, and are responsible for filtering down the relevant config themselves - previously miniflare plugins each declared a schema of what config it needed, and then each plugin would only receive that.

There is probably a lot of tidying up we can do in miniflare to strip out more unused bits, but trying to avoid too much in this PR.

A large chunk of the diff is in tests, where we call new Miniflare a lot. Inside miniflare this is migrated to the new config directly, outside miniflare we use the conversion helper.

As discussed the v4 to v5 conversion happens right before passing options to miniflare, meaning the new config format is not exposed in any public APIs (well other than miniflare's obviously).

TODO later:

there are a couple of exports from miniflare that are only used by vitest-pool-workers and not miniflare itself. for example, the config merging helper and compileModuleRules. In a follow up i will probably just move that directly into VPW.

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: miniflare v5 is wip

A picture of a cute animal (not mandatory, but encouraged)

[changeset-bot]

🦋 Changeset detected

Latest commit: 73ec8a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@cloudflare/config	Minor
miniflare	Major
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Minor
wrangler	Patch
@cloudflare/build-output-utils	Patch
@cloudflare/deploy-helpers	Patch
@cloudflare/pages-shared	Patch
@cloudflare/remote-bindings	Patch
@cloudflare/runtime-types	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ask-bonk]

UnknownError: ProviderInitError

github run

[ask-bonk]

@emily-shen Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

[github-actions]

✅ All changesets look good

[pkg-pr-new]

@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14994

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@14994

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@14994

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14994

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14994

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14994

miniflare

npm i https://pkg.pr.new/miniflare@14994

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@14994

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14994

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14994

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14994

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14994

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14994

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14994

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14994

wrangler

npm i https://pkg.pr.new/wrangler@14994

commit: 73ec8a5

[workers-devprod]

Codeowners approval required for this PR:

• @cloudflare/d1
• @cloudflare/workers-kv
• ✅ @cloudflare/wrangler

Show detailed file reviewers

• packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]
• packages/miniflare/test/plugins/kv/sites.spec.ts: [@cloudflare/workers-kv]
• packages/wrangler/src/d1/execute.ts: [@cloudflare/d1]
• packages/wrangler/src/d1/export.ts: [@cloudflare/d1]
• packages/wrangler/src/kv/helpers.ts: [@cloudflare/workers-kv]

[emily-shen]

Assets configuration
The converter drops supported fields from assets.routerConfig and assets.assetConfig, including existing static routing rules and inline headers/redirects.
These values were previously passed to the assets workers, so existing asset routing and response behaviour may change.

The dropped fields are now resolved once in miniflare instead of separately by consumers.

Workflow compatibility flags
The v4 schema and converter omit each workflow’s compatibilityFlags. The workflow plugin instead applies the user Worker’s compatibility flags to every workflow engine.
This both removes explicitly configured workflow flags and introduces unrelated Worker flags into the engine.

the workflow compat flags are the user compat flags, just previously the plugin didn't have access to those options so they were copied over.

Manual module path resolution
Relative paths in manually supplied modules were previously resolved against rootPath; modulesRoot only determined their runtime module names.
The converter now reads those files relative to modulesRoot, which can load the wrong file or fail with ENOENT whenever rootPath and modulesRoot differ.

devin had the same comment, i still don't really understand what the problem is here. what is the expected user facing breakage due to this change?

fixing the rest

[penalosa]

devin had the same comment, i still don't really understand what the problem is here. what is the expected user facing breakage due to this change?

Example project:

/project/
  src/index.mjs

new Miniflare({
  rootPath: "/project",
  modulesRoot: "src",
  modules: [{ type: "ESModule", path: "src/index.mjs" }],
});

Previously:

• File lookup: rootPath + path
• Reads /project/src/index.mjs
• Runtime module name: path relative to modulesRoot
• Name becomes index.mjs

Now:

• File lookup: modulesRoot + path
• Attempts /project/src/src/index.mjs
• Fails with ENOENT

[edmundhung]

Some findings from AI review 😅

[edmundhung]

We are getting there! Thanks for the hard work. 🙌🏼

[penalosa]

AI review of the tests, apologies in advance for any nonsense!

[penalosa]

A second pass over the non-test changes found these configuration and runtime gaps. I have omitted the expected module-discovery change and the issues already covered in my earlier review.

[workers-devprod]

Codeowners approval required for this PR:

• @cloudflare/d1
• @cloudflare/workers-kv
• ✅ @cloudflare/wrangler

Show detailed file reviewers

• packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]
• packages/miniflare/test/plugins/kv/sites.spec.ts: [@cloudflare/workers-kv]
• packages/wrangler/src/d1/execute.ts: [@cloudflare/d1]
• packages/wrangler/src/d1/export.ts: [@cloudflare/d1]
• packages/wrangler/src/kv/helpers.ts: [@cloudflare/workers-kv]

[edmundhung]

codeowners bypass

[workers-devprod]

Codeowners reviews satisfied