Add CI build and lint checks - #26
Merged
Merged
Conversation
davidtaing
reviewed
Aug 13, 2026
davidtaing
left a comment
davidtaing
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution @Fhatu12, looks good to me. Can you update the SHAs to the latest released versions? Some of these are on version 7 and 6.
Collaborator
|
By the way, how did you find the setup instructions @Fhatu12? Was it okay? |
Contributor
Author
|
Thanks, no worries, the setup instructions were good. I found the pnpm and Node version guidance especially useful, and AGENTS.md made the project conventions clear. I was able to get the project running and validate lint/build without any major issues. |
davidtaing
marked this pull request as ready for review
August 14, 2026 06:21
davidtaing
approved these changes
Aug 14, 2026
Collaborator
|
Approving, thank you for your contribution @Fhatu12 |
davidtaing
pushed a commit
that referenced
this pull request
Aug 14, 2026
Closes #6 ## What changed - configure Playwright to build and serve the production Next.js app - run the suite in desktop and mobile Chromium projects - smoke-test `/`, `/contact`, and the generated 404 route - cover menu focus containment and restoration, hash navigation, header fade behavior, and contact-form submission - run structural WCAG checks with `@axe-core/playwright`; existing palette contrast debt remains outside this harness change - add a standalone GitHub Actions workflow that installs Chromium and runs `pnpm test:e2e` ## Why Most routes are Server Components, so they need browser-level coverage. This gives the project a production-build smoke gate without overlapping the general build/lint workflow in #26. ## Verification - `pnpm lint` - `pnpm build` - `pnpm test:e2e` — 18 passed across desktop and mobile Chromium - `pnpm install --frozen-lockfile --lockfile-only` - `git diff --check` --------- Co-authored-by: Oniel Alejo Feliz <197416079+XonkelX@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
What this does
main.nvmrcVerification
pnpm install --frozen-lockfilepnpm lintpnpm buildgit diff --checkThe issue also requires live evidence that CI rejects both lint and build failures. Keep this PR as draft until those checks are demonstrated.