feat!: set canister env in cookies for html files - #4387
Merged
Conversation
viviveevee
reviewed
Sep 24, 2025
Co-authored-by: Vivienne Siffert <severin.siffert@dfinity.org>
ilbertt
marked this pull request as ready for review
September 25, 2025 12:16
Additionally, fixes tests
3 tasks
Contributor
Author
|
After merging #4392, we should be able to fix tests here |
ilbertt
changed the title
viviveevee
reviewed
Sep 26, 2025
viviveevee
left a comment
viviveevee
left a comment
Contributor
There was a problem hiding this comment.
Can you also add a test that shows that PUBLIC_ env vars are added to the cookie?
Contributor
Author
Adding them in a follow-up PR |
viviveevee
approved these changes
Sep 26, 2025
ilbertt
added a commit
that referenced
this pull request
Sep 26, 2025
After #4387, some methods already have two parameters (time and canister env) that can be condensed into a "system context". Using a system context simplifies the tests as well. This PR introduces the `system_context` module and refactors the state methods to accept is as the last argument. --------- Co-authored-by: Vivienne Siffert <severin.siffert@dfinity.org>
This was referenced Sep 26, 2025
ilbertt
added a commit
that referenced
this pull request
Oct 2, 2025
This was referenced Oct 5, 2025
ilbertt
added a commit
to dfinity/icp-cli
that referenced
this pull request
Oct 9, 2025
dfinity/sdk#4387 enables asset canisters to serve the canister environment variables prefixed with `PUBLIC_` in the `ic_env` cookie. Additionally, switches the frontend-environment-variables asset canister to the one hosted on GitHub, which supports the `ic_env` cookie. Additionally, aligns the doc comments to the latest pushes on dfinity/icp-js-core#1156.
ilbertt
added a commit
to dfinity/icp-js-core
that referenced
this pull request
Oct 22, 2025
…#1156) Introduces the `getCanisterEnv` and `safeGetCanisterEnv` functions to load the canister environment from the `ic_env` cookie. This is an _experimental_ feature. Additionally, adds the `@types/jsdom` package to the dev dependencies to avoid typescript errors. Related: dfinity/sdk#4387.
Merged
3 tasks
ilbertt
added a commit
that referenced
this pull request
Dec 23, 2025
…r environment changed (#4446) # Description Sets the `ic_env` cookie for all HTML files only if the canister environment changed in the `commit_batch` method. The feature was first introduced in #4387. # How Has This Been Tested? Successfully deployed the [dfinity/portal](https://github.com/dfinity/portal) locally.
adamspofford-dfinity
pushed a commit
that referenced
this pull request
Dec 23, 2025
…r environment changed (#4446) # Description Sets the `ic_env` cookie for all HTML files only if the canister environment changed in the `commit_batch` method. The feature was first introduced in #4387. # How Has This Been Tested? Successfully deployed the [dfinity/portal](https://github.com/dfinity/portal) locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Returns the
ic_envcookie for all the html files. The cookie includes the root key and all the canister environment variables prefixed withPUBLIC_.How Has This Been Tested?
Tests will be added in a follow-up PR.
Checklist: