Bump moby/moby vendoring and fix tests - #1504
Merged
Merged
Conversation
simonferquel
requested review from
silvin-lubecki and
vdemeester
as code owners
November 8, 2018 08:34
Contributor
Author
AkihiroSuda
approved these changes
Nov 8, 2018
AkihiroSuda
left a comment
AkihiroSuda
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, LGTM if green
vdemeester
suggested changes
Nov 8, 2018
vdemeester
left a comment
vdemeester
left a comment
Collaborator
There was a problem hiding this comment.
?? vendor/github.com/docker/docker/contrib/
?? vendor/golang.org/x/crypto/otr/
?? vendor/golang.org/x/crypto/ssh/test/
?? vendor/golang.org/x/sys/cpu/
?? vendor/golang.org/x/sys/windows/svc/
?? vendor/k8s.io/kubernetes/build/
validation of the vendor fails, otherwise 👍
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
A recent change in moby/moby made tests with missing client mocks fail with panic. This adds those missing mocks for the impacted tests. Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
simonferquel
force-pushed
the
bump-moby-fix-tests
branch
from
November 8, 2018 10:38
3a00f19 to
8efa6a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1504 +/- ##
=======================================
Coverage 55.14% 55.14%
=======================================
Files 289 289
Lines 19371 19371
=======================================
Hits 10683 10683
+ Misses 7997 7996 -1
- Partials 691 692 +1 |
Contributor
Author
|
@vdemeester It was a mismatch of vndr version between my dev env and the CLI dev image. Fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change in moby/moby (moby/moby@3e5b9cb#diff-ac3eb5494dc3178ea5947441c086942b) made tests with missing client function mocks fail with a panic (underlying http client is nil within unit tests). This PR bumps Moby/moby and fix the impacted tests by adding missing mock functions.
- What I did
- How I did it
- How to verify it
Run unit tests