Skip to content

Corrected descriptions for MAC_ADMIN and MAC_OVERRIDE - #761

Merged
thaJeztah merged 1 commit into
docker:masterfrom
sourabhtk37:patch-1
Dec 21, 2017
Merged

Corrected descriptions for MAC_ADMIN and MAC_OVERRIDE#761
thaJeztah merged 1 commit into
docker:masterfrom
sourabhtk37:patch-1

Conversation

@sourabhtk37

Copy link
Copy Markdown
Contributor

The description for capabilities are mismatched for MAC_ADMIN and MAC_OVERRIDE.
You can find the correct information here on the linux man page.

@codecov-io

codecov-io commented Dec 21, 2017

Copy link
Copy Markdown

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         218      218           
  Lines       14613    14613           
=======================================
  Hits         7811     7811           
  Misses       6321     6321           
  Partials      481      481

The description for capabilities are mismatched for MAC_ADMIN and MAC_OVERRIDE.

Signed-off-by: T K Sourabh <sourabhtk37@gmail.com>

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
cc @thaJeztah

@thaJeztah

Copy link
Copy Markdown
Member

Looks like it was always swapped, and we never noticed; moby/moby#11861, nice catch @sourabhtk37!

@thaJeztah
thaJeztah merged commit ebb8927 into docker:master Dec 21, 2017
@GordonTheTurtle GordonTheTurtle added this to the 18.01.0 milestone Dec 21, 2017
@sourabhtk37

Copy link
Copy Markdown
Contributor Author

No problem @thaJeztah

nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Corrected descriptions for MAC_ADMIN and MAC_OVERRIDE
Upstream-commit: ebb8927
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants