bump compose-go to version v2.14.0

[glours]

What I did
Bump compose-go to version v2.14.0

Related issue
N/A

(not mandatory) A picture of a cute animal, if possible in relation to what you did

[docker-agent]

Assessment: 🟢 APPROVE

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[thaJeztah]

diff; compose-spec/compose-go@e70e961...v2.14.0

[thaJeztah]

Not a blocker, but perhaps that joinErrors should match errors.Join; it currently ignores empty slices, but does not check for nil-errors (which errors.Join does), so it could panic if the slice of errors would contain a nil error;

func joinErrors(errs []error) error {
	if len(errs) == 0 {
		return nil
	}
	slices.SortStableFunc(errs, func(a, b error) int {
		return slices.Compare(errorPath(a), errorPath(b))
	})
	return errors.Join(errs...)
}

This would panic (err.Error());

func errorPath(err error) []string {
	var pe pathError
	if errors.As(err, &pe) {
		return pe.path.Parts()
	}
	return []string{err.Error()}
}

(possibly the pathError error-type could also provide a Cmp helper for the sorting); wondering though if we should look at an exported error-type (I think BuildKit has something for the Dockerfile parsing errors), that could point to the path and line the error occurred in the compose-file (or are these different)?

[thaJeztah]

LGTM

[thaJeztah]

(possibly the pathError error-type could also provide a Cmp helper for the sorting)

Mostly thinking here to keep sorting and joining separate. The joinErrors makes it feel too much like a generic utility, but it should only be used for these specific cases, so making it transparent "sort path errors before joining" also makes it more transparent that we're doing something special;

func sortPathErrors(errs []error) {
	slices.SortStableFunc(errs, func(a, b error) int {
		return slices.Compare(errorPath(a), errorPath(b))
	})
}

☝️ should have some guards for empty slices and nil errors.

Then sort before joining;

sortPathErrors(errs)
return out, errors.Join(errs...)