fix(eval): preserve budget termination outcomes - #3862
Merged
Conversation
trungutt
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
budget_exceededoutcomes as allow-listed evaluation termination metadataeval_result.terminationdata without changing scoring or error semanticsmessage_addedpayloads private by carrying the budget stop through a dedicated narrow runtime DTOCloses #3845
Acceptance criteria
budget_exceededmaps toreason,budget,limit,used,max,config_path, andmessageonlymessage_addedevents remain payload-free and ignored by evaluation reconstruction; only the dedicated budgetstop_messageDTO is retainedsession_items.message_jsonstorage withitem_type = termination, requiring no migrationeval_result.terminationsurvive serialization and reloadpassed, failures, errors, or scoring inputsValidation
env -u HTTP_PROXY -u HTTPS_PROXY -u ALL_PROXY -u http_proxy -u https_proxy -u all_proxy go test ./...go build ./...go vet ./pkg/runtime ./pkg/evaluation ./pkg/sessiongolangci-lint run ./pkg/runtime/... ./pkg/evaluation/... ./pkg/session/...go run ./lint .npx --yes markdownlint-cli2@0.22.1 configuration/budget/index.mdfromdocs/./scripts/docs-check-canonical.shgit diff --checkManual validation
Not run. A live budget-triggered evaluation would require a configured model/provider. Deterministic runtime, parser, chronology, persistence, compatibility, isolation, and security coverage is included in the automated tests.