Evaluate rows on addEmptyIndex - #105
Merged
Merged
Conversation
JonoPrest
force-pushed
the
jp/fix-add-empty-index
branch
from
August 5, 2024 15:32
be16ec7 to
a5df722
Compare
Merged
JonoPrest
force-pushed
the
jp/fix-add-empty-index
branch
from
August 6, 2024 07:33
a5df722 to
8895eb7
Compare
DZakh
approved these changes
Aug 6, 2024
Comment on lines
372
to
373
| Assert.deepEqual( | ||
| mock.loadEntitiesByFieldCalls, |
Member
There was a problem hiding this comment.
Is it correct that we still call loadEntitiesByField?
Collaborator
Author
There was a problem hiding this comment.
Yes if it's the first time adding the index 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes edge case where values already exist in the inMemory store when the lookup by index gets run.