Skip to content

Fuel merge part 2 - include HyperFuelWorker into the hbs template - #134

Merged
DZakh merged 6 commits into
mainfrom
dz/fuel-merge
Aug 22, 2024
Merged

Fuel merge part 2 - include HyperFuelWorker into the hbs template#134
DZakh merged 6 commits into
mainfrom
dz/fuel-merge

Conversation

@DZakh

@DZakh DZakh commented Aug 21, 2024

Copy link
Copy Markdown
Member

Also:

  • Updated fuel greeter template to include ecosystem field, which will be mandatory after merge
  • Added fuel_greeter test scenario - currently not working with local package version
  • Removed the event_decoder field from system_config, so it's more generic and doesn't have ecosystem-specific dependencies.
  • Removed alternative playground from init templates

@DZakh
DZakh requested a review from JonoPrest August 21, 2024 15:33
Comment thread scenarios/fuel_greeter/index.html Outdated
Comment on lines +1 to +21

<!--
* Copyright (c) 2021 GraphQL Contributors
* All rights reserved.
*
* This source code is licensed under the license found in the
* LICENSE file in the root directory of this source tree.
-->
<!DOCTYPE html>
<html lang="en">
<head>
<title>GraphiQL</title>
<style>
body {
height: 100%;
margin: 0;
width: 100%;
overflow: hidden;
}

#graphiql {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an artifact from the old fork. Maybe we remove this? It's just graphql playgroud alternative to hasura.

@JonoPrest JonoPrest left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Dmitry 👍🏼

@DZakh
DZakh enabled auto-merge (squash) August 22, 2024 09:14
@DZakh
DZakh merged commit dff9659 into main Aug 22, 2024
@DZakh
DZakh deleted the dz/fuel-merge branch August 22, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants