Opt out of rollback on reorg for templates - #154
Merged
Conversation
moose-code
reviewed
Aug 29, 2024
| }, | ||
| "rollback_on_reorg": { | ||
| "description": "A flag to indicate if the indexer should rollback to the last known valid block on a reorg (default: true)", | ||
| "description": "A flag to indicate if the indexer should rollback to the last known valid block on a reorg. This currently incurs a performance hit one historical sync and is recommended to to turn this off while developing (default: true)", |
Member
There was a problem hiding this comment.
Suggested change
| "description": "A flag to indicate if the indexer should rollback to the last known valid block on a reorg. This currently incurs a performance hit one historical sync and is recommended to to turn this off while developing (default: true)", | |
| "description": "A flag to indicate if the indexer should rollback to the last known valid block on a reorg. This currently incurs a performance hit on historical sync and is recommended to turn this off while developing (default: true)", |
moose-code
reviewed
Aug 29, 2024
Comment on lines
+149
to
+151
| valid block on a reorg. This currently incurs a performance hit one \ | ||
| historical sync and is recommended to to turn this off while \ | ||
| developing (default: true)" |
Member
There was a problem hiding this comment.
Suggested change
| valid block on a reorg. This currently incurs a performance hit one \ | |
| historical sync and is recommended to to turn this off while \ | |
| developing (default: true)" | |
| valid block on a reorg. This currently incurs a performance hit on \ | |
| historical sync and is recommended to turn this off while \ | |
| developing (default: true)" |
Collaborator
Author
There was a problem hiding this comment.
Thanks JJ, I copied this in locally and ran the generator to output the schema 👍🏼
moose-code
reviewed
Aug 29, 2024
Comment on lines
+14
to
+16
| # Rollback on reorg mode currently incurs a performance hit on historical sync | ||
| # while developing an indexer we recommend setting this to false | ||
| rollback_on_reorg: false |
Collaborator
Author
There was a problem hiding this comment.
Cool just to note, this message won't be in contract import templates.
moose-code
approved these changes
Aug 29, 2024
moose-code
left a comment
moose-code
left a comment
Member
There was a problem hiding this comment.
Just a couple spelling change suggestions!
lots of liniting changes it seems, glossed over.
Nice!!
Reword description
JonoPrest
force-pushed
the
jp/opt-out-rollback
branch
from
August 29, 2024 08:37
90885ce to
f8abd65
Compare
DZakh
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it incurs a performance hit on historical sync. For starting up and development we want to encourage people to turn it off until they deploy for production.