Skip to content

Script to help update chains - #162

Merged
DZakh merged 9 commits into
mainfrom
script-to-help-update-chains
Sep 2, 2024
Merged

Script to help update chains#162
DZakh merged 9 commits into
mainfrom
script-to-help-update-chains

Conversation

@JasoonS

@JasoonS JasoonS commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

image

This makes it much easier to add/remove chains. This is an intermediate solution until we implement dotfiles or similar.

@JasoonS
JasoonS changed the base branch from main to update-latest-chains August 30, 2024 15:36
@JasoonS
JasoonS requested review from DZakh and JonoPrest August 30, 2024 16:35
@JonoPrest
JonoPrest force-pushed the update-latest-chains branch 5 times, most recently from 4fe68c6 to bdefa64 Compare September 2, 2024 10:24
Base automatically changed from update-latest-chains to main September 2, 2024 10:28
@JonoPrest
JonoPrest force-pushed the script-to-help-update-chains branch from 84b0cbc to 0e41b88 Compare September 2, 2024 10:42

@DZakh DZakh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JonoPrest
JonoPrest requested a review from DZakh September 2, 2024 11:08
@JonoPrest

Copy link
Copy Markdown
Collaborator

@DZakh I've moved it to the cli module. I think it will be helpful to add scripts/tools to the hidden "script" subcommand. Then it becomes easy to extend

Comment thread codegenerator/cli/Makefile Outdated

@DZakh DZakh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I only don't like that it's a part of the published binary, but we can solve this later.

@DZakh
DZakh merged commit bfe6ae1 into main Sep 2, 2024
@DZakh
DZakh deleted the script-to-help-update-chains branch September 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants