Reintroduce db_write_timestamp wield to avoid breaking changes - #17
Merged
Conversation
Collaborator
Author
|
Also some tests were broken. I'm not sure how, they were passing in the PR before merge as far as I'm aware. |
DZakh
approved these changes
Jun 6, 2024
DZakh
left a comment
Member
There was a problem hiding this comment.
Maybe they didn't run because a merge conflict or something
Member
|
And they are failing even now 🤔 |
DZakh
force-pushed
the
integration-testing-db-write-ts
branch
from
June 7, 2024 10:47
bf200e8 to
cd1a83c
Compare
JonoPrest
commented
Jun 7, 2024
JonoPrest
left a comment
Collaborator
Author
There was a problem hiding this comment.
Nice! Thank you 👍🏼
Member
Collaborator
Author
Collaborator
Author
|
@DZakh array flags were missing! 🙏🏼 thank you integration tests 👼🏼 and thanks for spotting the issue. Let's see if we pass now. |
JonoPrest
force-pushed
the
integration-testing-db-write-ts
branch
from
June 7, 2024 12:56
3f646d8 to
e41a19c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The integration tests were failing because I removed db_write_timestamp field from user entities.
I did this because during refactor I though why are we enforcing this field for users. (We did it early on to try and capture some metrics of the indexer)
So I removed it but I realise this is a breaking change if anyone is actually using that field with Hasura/postgres queries.
We can remove in v2 but not in v1