Skip to content

Reintroduce db_write_timestamp wield to avoid breaking changes - #17

Merged
JonoPrest merged 4 commits into
mainfrom
integration-testing-db-write-ts
Jun 7, 2024
Merged

Reintroduce db_write_timestamp wield to avoid breaking changes#17
JonoPrest merged 4 commits into
mainfrom
integration-testing-db-write-ts

Conversation

@JonoPrest

Copy link
Copy Markdown
Collaborator

The integration tests were failing because I removed db_write_timestamp field from user entities.

I did this because during refactor I though why are we enforcing this field for users. (We did it early on to try and capture some metrics of the indexer)

So I removed it but I realise this is a breaking change if anyone is actually using that field with Hasura/postgres queries.

We can remove in v2 but not in v1

@JonoPrest
JonoPrest requested a review from DZakh June 6, 2024 12:11
@JonoPrest

Copy link
Copy Markdown
Collaborator Author

Also some tests were broken. I'm not sure how, they were passing in the PR before merge as far as I'm aware.

@DZakh DZakh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe they didn't run because a merge conflict or something

@DZakh

DZakh commented Jun 6, 2024

Copy link
Copy Markdown
Member

And they are failing even now 🤔

@DZakh
DZakh force-pushed the integration-testing-db-write-ts branch from bf200e8 to cd1a83c Compare June 7, 2024 10:47

@JonoPrest JonoPrest left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you 👍🏼

@DZakh

DZakh commented Jun 7, 2024

Copy link
Copy Markdown
Member

I don't like that integration tests are also failing. According to the logs greetings is a string instead of an array of strings

image

Maybe the db column type has changed. I'm not familiar with the part of the code.

@JonoPrest

Copy link
Copy Markdown
Collaborator Author

I don't like that integration tests are also failing. According to the logs greetings is a string instead of an array of strings

image Maybe the db column type has changed. I'm not familiar with the part of the code.

I'm looking at it now. Definitely something funky

@JonoPrest

Copy link
Copy Markdown
Collaborator Author

@DZakh array flags were missing! 🙏🏼 thank you integration tests 👼🏼 and thanks for spotting the issue. Let's see if we pass now.

@JonoPrest
JonoPrest force-pushed the integration-testing-db-write-ts branch from 3f646d8 to e41a19c Compare June 7, 2024 12:56
@JonoPrest
JonoPrest merged commit ca9362b into main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants