Update chains and move test to integration tests - #314
Merged
Conversation
JonoPrest
commented
Nov 1, 2024
Comment on lines
+145
to
+146
| if diff.missing_chains.is_empty() && diff.extra_chains.is_empty() { | ||
| return; |
Collaborator
Author
There was a problem hiding this comment.
Also just a note I fixed this to use && instead of || since it was not failing when it should have.
DZakh
approved these changes
Nov 1, 2024
DZakh
force-pushed
the
jp/update-chains-and-test
branch
from
November 1, 2024 14:26
5263646 to
216be33
Compare
JonoPrest
enabled auto-merge (rebase)
November 1, 2024 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.