Skip to content

Remove debug loggers - #339

Merged
JonoPrest merged 1 commit into
mainfrom
dz/remove-debug-logger
Nov 19, 2024
Merged

Remove debug loggers#339
JonoPrest merged 1 commit into
mainfrom
dz/remove-debug-logger

Conversation

@DZakh

@DZakh DZakh commented Nov 15, 2024

Copy link
Copy Markdown
Member

Noticed this in the logs:
image

It is also worth investigating why it's called so many times.

@DZakh
DZakh requested a review from JonoPrest November 15, 2024 13:34
@DZakh

DZakh commented Nov 15, 2024

Copy link
Copy Markdown
Member Author

@JonoPrest JonoPrest left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably means we're making more get height queries than necessary.

@JonoPrest
JonoPrest force-pushed the dz/remove-debug-logger branch from 22ffc0a to 954d05a Compare November 19, 2024 07:37
@JonoPrest
JonoPrest enabled auto-merge (rebase) November 19, 2024 07:37
@JonoPrest
JonoPrest merged commit 449b4d1 into main Nov 19, 2024
@JonoPrest
JonoPrest deleted the dz/remove-debug-logger branch November 19, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants