Skip to content

Allow naming entities as: Schema, Belt, EntityHistory, InternalEntity, Entity, Utils - #353

Merged
DZakh merged 4 commits into
mainfrom
dz/move-to-npm-package
Nov 22, 2024
Merged

Allow naming entities as: Schema, Belt, EntityHistory, InternalEntity, Entity, Utils#353
DZakh merged 4 commits into
mainfrom
dz/move-to-npm-package

Conversation

@DZakh

@DZakh DZakh commented Nov 21, 2024

Copy link
Copy Markdown
Member
  • Vendor @ryyppy/rescript-promise to reduce installation and compile time
  • Move more files into the npm package from codegen.
  • Improve dependency graph to depend less on the generated files and improve modularity and testing
  • Deleted unused code from DbFunctions
  • Moved global Db state into the single Db.res module. DbFunctions.res doesn’t contain any global state anymore
  • Restructured the Entites.res modules, so now ReScript doesn’t complain on entities with the following names: Schema, Belt, EntityHistory, InternalEntity, Entity, Utils. Previously there were name collisions which wouldn’t allow to name entities in schema.graphql like this.

@DZakh
DZakh requested review from JasoonS and JonoPrest November 22, 2024 09:51
@DZakh DZakh changed the title Move pg to npm package and vendore promise bindings Allow naming entities as: Schema, Belt, EntityHistory, InternalEntity, Entity, Utils Nov 22, 2024

@JasoonS JasoonS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - it looks good on reading through. Didn't analyse super deeply - but in the type system I trust 💪

@DZakh
DZakh merged commit 741bc12 into main Nov 22, 2024
@DZakh
DZakh deleted the dz/move-to-npm-package branch November 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants