Discard invalid tasks - #387
Merged
Merged
Conversation
DenhamPreen
approved these changes
Dec 17, 2024
DZakh
commented
Dec 17, 2024
Comment on lines
+46
to
+47
| S.taskReducer(self.state, task, ~dispatchAction=action => | ||
| dispatchAction(~stateId, self, action) |
Member
Author
There was a problem hiding this comment.
We could have stateId=0 and self.state with id 1, which would lead to invalid state in reducer. Maybe not critical in the latest envio version, but it caused a bug in the one I'm currently testing.
Collaborator
|
Wow good catch @DZakh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it causes indexer freeze after preRegistration is done on the
2.11.3pre-release.I can explain in detail the problems with the old behavior on a call.
It's safe to discard all tasks with unmatching stateId.
Also, I've added support for
ErrorExitaction in the invalidatedActionReducer. Without it, the indexer couldn't gracefully crash during the rollback or when preRegistration is done.