Fix indexer stopping fetching nested dynamic contract registrations on restart when a preRegistration is used - #411
Merged
Conversation
Contributor
|
Great find and fix @DZakh 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug reproduction:
Terminology:
The issue was caused by incorrect dc recovering logic when we have an event with preRegistration.
Without preRegistration we recover all dcs registered before or equal to the start block, while with preRegistration event this logic is changed to get all events with preRegistration and extract them from the db. Even though it sounds broken, but this worked in 95% of the usecases, besides when we got new dc registrations after preRegistration. It caused two bugs:
To solve the problem:
is_pre_registeredflag to the dc entity in the db, so it's possible to correctly get all preRegistered dcs from db correctly for both 1 and 2 cases mentioned above.is_pre_registeredflagUnrelated issue I solved:
If a single event registers multiple dcs with the same addresses, the duplicate wasn't detected correctly.