Don't query events without handlers - #425
Merged
Merged
Conversation
DZakh
commented
Jan 17, 2025
DZakh
commented
Member
DZakh
commented
Jan 17, 2025
| ~enableRawEvents, | ||
| ): t => { | ||
| let module(ChainWorker) = chainConfig.chainWorker | ||
| logger->Logging.childInfo("Initializing ChainFetcher with " ++ ChainWorker.name ++ " worker") |
Member
Author
There was a problem hiding this comment.
Removed the log since I couldn't find any value in it.
Collaborator
There was a problem hiding this comment.
I suppose the main value is to be able to see rpc vs hypersync for a given chain.
JonoPrest
reviewed
Jan 20, 2025
Comment on lines
+231
to
+237
| // const burnSchema = S.object({ | ||
| // subId: S.string, | ||
| // amount: SExtra.bigint, | ||
| // }); | ||
| // AllEvents.Burn.handler(async ({ event }) => { | ||
| // burnSchema.assert(event.params)!; | ||
| // expectType<AssertSchemaType<typeof event.params, typeof burnSchema>>(true); |
Collaborator
There was a problem hiding this comment.
What's happening with this test?
Member
Author
There was a problem hiding this comment.
Oh, I wanted to show the case when a handler is missing. I'll add it back in a future PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
