More robust reorg detection logic - #447
Merged
Merged
Conversation
JonoPrest
reviewed
Feb 4, 2025
Comment on lines
+121
to
+127
| ) { | ||
| | Some(scannedBlock) if scannedBlock.blockHash !== lastBlockScannedData.blockHash => | ||
| Some({ | ||
| reorgGuard, | ||
| scannedBlock, | ||
| }) | ||
| | _ => |
Collaborator
There was a problem hiding this comment.
Maybe leave a comment explaining why the check for lastBlockScannedData
JonoPrest
reviewed
Feb 4, 2025
| let lastBlockQueriedPromise: promise< | ||
| ReorgDetection.blockData, | ||
| > = // switch pageUnsafe.rollbackGuard { | ||
| let lastBlockQueriedPromise = // switch pageUnsafe.rollbackGuard { |
JonoPrest
approved these changes
Feb 4, 2025
JonoPrest
left a comment
JonoPrest
left a comment
Collaborator
There was a problem hiding this comment.
Great work Dmitry! This looks much better than before 💪🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firstBlockParentNumberAndHashin the scanned block data, so it's possible to use it to detect a rollbackheighestBlockBelowThresholdinstead of start of the chain or some other weird place.