Generalize loader batching logic to support effects - #505
Merged
Conversation
DZakh
changed the title
DZakh
commented
Apr 14, 2025
Comment on lines
+101
to
+106
| Logging.setLogger( | ||
| ~logStrategy, | ||
| ~logFilePath, | ||
| ~defaultFileLogLevel, | ||
| ~userLogLevel, | ||
| ) |
Member
Author
There was a problem hiding this comment.
Not pefect, but currently allows to move quite some code from generated
Collaborator
|
Looks like tests are failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move more code into npm package.
Currently there are no changes in the
LoadLayerlogic, besides the parthyperindex/codegenerator/cli/templates/static/codegen/src/LoadLayer.res
Lines 242 to 247 in 16e6f6b