Skip to content

Remove deprecated scenarios - #537

Merged
DZakh merged 1 commit into
mainfrom
codex/remove-old-scenarios-ploffen-simple-bank-nft-factory
May 20, 2025
Merged

Remove deprecated scenarios#537
DZakh merged 1 commit into
mainfrom
codex/remove-old-scenarios-ploffen-simple-bank-nft-factory

Conversation

@moose-code

@moose-code moose-code commented May 20, 2025

Copy link
Copy Markdown
Member

Summary

  • delete deprecated ploffen, simple_bank, and nft-factory scenarios

Testing

  • cargo test --no-default-features --verbose (fails: Could not connect to server)

Summary by CodeRabbit

  • Chores
    • Removed all files and documentation related to the NFT Factory, Ploffen, and Simple Bank scenarios, including smart contracts, deployment scripts, configuration files, GraphQL schemas, event handlers, tasks, and related documentation.
  • Bug Fixes
    • None.
  • New Features
    • None.
  • Documentation
    • Removed all scenario-specific README and instructional files.

These changes remove the ability to interact with, deploy, or index data for the affected scenarios.

@coderabbitai

coderabbitai Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This change removes all files related to three blockchain application scenarios: NFT Factory, Ploffen, and Simple Bank. The deletions encompass smart contract source code, deployment scripts, configuration files, GraphQL schemas, event handler implementations, ABIs, documentation, and supporting package files. No code, configuration, or documentation remains for these scenarios in the repository.

Changes

File(s) / Path(s) Change Summary
scenarios/nft-factory/README.md, scenarios/nft-factory/config.yaml, scenarios/nft-factory/config.fuji.yaml, scenarios/nft-factory/schema.graphql, scenarios/nft-factory/src/EventHandlers.ts Deleted all documentation, configuration, GraphQL schema, and event handler files for the NFT Factory scenario.
scenarios/nft-factory/abis/NftFactory.json, scenarios/nft-factory/abis/SimpleNft.json Deleted ABI JSON files for the NftFactory and SimpleNft contracts.
scenarios/nft-factory/contracts/README.md, scenarios/nft-factory/contracts/.gitignore, scenarios/nft-factory/contracts/package.json Deleted contract documentation, .gitignore, and package configuration for NFT Factory contracts.
scenarios/nft-factory/contracts/contracts/NftFactory.sol, scenarios/nft-factory/contracts/contracts/SimpleNft.sol Deleted Solidity source code for NftFactory and SimpleNft contracts.
scenarios/nft-factory/contracts/deploy/deploy.js Deleted Hardhat deployment script for NFT Factory contracts.
scenarios/nft-factory/contracts/deployments/fuji/.chainId, scenarios/nft-factory/contracts/deployments/fuji/solcInputs/bf545600cc7f64ad89f68da4537bebcf.json Deleted deployment artifacts for Fuji network.
scenarios/nft-factory/contracts/tasks/index.js, scenarios/nft-factory/contracts/tasks/newSimpleNftTask.js, scenarios/nft-factory/contracts/tasks/mintSimpleNftTask.js Deleted Hardhat task scripts for NFT creation and minting.
scenarios/ploffen/contracts/README.md, scenarios/ploffen/contracts/.gitignore, scenarios/ploffen/contracts/package.json Deleted contract documentation, .gitignore, and package configuration for Ploffen contracts.
scenarios/ploffen/contracts/abis/IERC20.json, scenarios/ploffen/contracts/abis/Ploffen.json Deleted ABI JSON files for IERC20 and Ploffen contracts.
scenarios/ploffen/contracts/contracts/GameToken.sol, scenarios/ploffen/contracts/contracts/Ploffen.sol Deleted Solidity source code for GameToken and Ploffen contracts.
scenarios/ploffen/contracts/deploy/deploy.js Deleted Hardhat deployment script for Ploffen contracts.
scenarios/ploffen/contracts/hardhat.config.js Deleted Hardhat configuration for Ploffen contracts.
scenarios/ploffen/contracts/tasks/index.js, scenarios/ploffen/contracts/tasks/playPloffenTask.js, scenarios/ploffen/contracts/tasks/winPloffenTask.js Deleted Hardhat task scripts for playing and winning the Ploffen game.
scenarios/ploffen/indexer/README.md, scenarios/ploffen/indexer/config.yaml, scenarios/ploffen/indexer/schema.graphql, scenarios/ploffen/indexer/src/EventHandlers.res Deleted indexer documentation, configuration, GraphQL schema, and event handler implementation for Ploffen scenario.
scenarios/simple_bank/README.md, scenarios/simple_bank/config.yaml, scenarios/simple_bank/schema.graphql, scenarios/simple_bank/src/EventHandlers.ts Deleted documentation, configuration, GraphQL schema, and event handler files for the Simple Bank scenario.
scenarios/simple_bank/contracts/.gitignore, scenarios/simple_bank/contracts/package.json Deleted .gitignore and package configuration for Simple Bank contracts.
scenarios/simple_bank/contracts/abis/SimpleBank.json Deleted ABI JSON file for SimpleBank contract.
scenarios/simple_bank/contracts/contracts/SimpleBank.sol Deleted Solidity source code for SimpleBank contract.
scenarios/simple_bank/contracts/deploy/deploy.js Deleted Hardhat deployment script for SimpleBank contract.
scenarios/simple_bank/contracts/hardhat.config.js Deleted Hardhat configuration for SimpleBank contracts.
scenarios/simple_bank/contracts/tasks/index.js, scenarios/simple_bank/contracts/tasks/newAccountTask.js, scenarios/simple_bank/contracts/tasks/makeDepositTask.js, scenarios/simple_bank/contracts/tasks/makeWithdrawalTask.js Deleted Hardhat task scripts for account creation, deposit, and withdrawal in Simple Bank scenario.

Poem

The files are gone, the code is bare,
No banks, no tokens, not a hare!
Contracts, configs, docs—farewell,
The blockchain tales no longer dwell.
But in the repo’s empty glen,
A rabbit dreams: “We’ll build again!”
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8afb15b and bad22ee.

⛔ Files ignored due to path filters (2)
  • scenarios/nft-factory/contracts/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • scenarios/ploffen/contracts/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (48)
  • scenarios/nft-factory/README.md (0 hunks)
  • scenarios/nft-factory/abis/NftFactory.json (0 hunks)
  • scenarios/nft-factory/abis/SimpleNft.json (0 hunks)
  • scenarios/nft-factory/config.fuji.yaml (0 hunks)
  • scenarios/nft-factory/config.yaml (0 hunks)
  • scenarios/nft-factory/contracts/.gitignore (0 hunks)
  • scenarios/nft-factory/contracts/README.md (0 hunks)
  • scenarios/nft-factory/contracts/contracts/NftFactory.sol (0 hunks)
  • scenarios/nft-factory/contracts/contracts/SimpleNft.sol (0 hunks)
  • scenarios/nft-factory/contracts/deploy/deploy.js (0 hunks)
  • scenarios/nft-factory/contracts/deployments/fuji/.chainId (0 hunks)
  • scenarios/nft-factory/contracts/deployments/fuji/solcInputs/bf545600cc7f64ad89f68da4537bebcf.json (0 hunks)
  • scenarios/nft-factory/contracts/package.json (0 hunks)
  • scenarios/nft-factory/contracts/tasks/index.js (0 hunks)
  • scenarios/nft-factory/contracts/tasks/mintSimpleNftTask.js (0 hunks)
  • scenarios/nft-factory/contracts/tasks/newSimpleNftTask.js (0 hunks)
  • scenarios/nft-factory/schema.graphql (0 hunks)
  • scenarios/nft-factory/src/EventHandlers.ts (0 hunks)
  • scenarios/ploffen/contracts/.gitignore (0 hunks)
  • scenarios/ploffen/contracts/README.md (0 hunks)
  • scenarios/ploffen/contracts/abis/IERC20.json (0 hunks)
  • scenarios/ploffen/contracts/abis/Ploffen.json (0 hunks)
  • scenarios/ploffen/contracts/contracts/GameToken.sol (0 hunks)
  • scenarios/ploffen/contracts/contracts/Ploffen.sol (0 hunks)
  • scenarios/ploffen/contracts/deploy/deploy.js (0 hunks)
  • scenarios/ploffen/contracts/hardhat.config.js (0 hunks)
  • scenarios/ploffen/contracts/package.json (0 hunks)
  • scenarios/ploffen/contracts/tasks/index.js (0 hunks)
  • scenarios/ploffen/contracts/tasks/playPloffenTask.js (0 hunks)
  • scenarios/ploffen/contracts/tasks/winPloffenTask.js (0 hunks)
  • scenarios/ploffen/indexer/README.md (0 hunks)
  • scenarios/ploffen/indexer/config.yaml (0 hunks)
  • scenarios/ploffen/indexer/schema.graphql (0 hunks)
  • scenarios/ploffen/indexer/src/EventHandlers.res (0 hunks)
  • scenarios/simple_bank/README.md (0 hunks)
  • scenarios/simple_bank/config.yaml (0 hunks)
  • scenarios/simple_bank/contracts/.gitignore (0 hunks)
  • scenarios/simple_bank/contracts/abis/SimpleBank.json (0 hunks)
  • scenarios/simple_bank/contracts/contracts/SimpleBank.sol (0 hunks)
  • scenarios/simple_bank/contracts/deploy/deploy.js (0 hunks)
  • scenarios/simple_bank/contracts/hardhat.config.js (0 hunks)
  • scenarios/simple_bank/contracts/package.json (0 hunks)
  • scenarios/simple_bank/contracts/tasks/index.js (0 hunks)
  • scenarios/simple_bank/contracts/tasks/makeDepositTask.js (0 hunks)
  • scenarios/simple_bank/contracts/tasks/makeWithdrawalTask.js (0 hunks)
  • scenarios/simple_bank/contracts/tasks/newAccountTask.js (0 hunks)
  • scenarios/simple_bank/schema.graphql (0 hunks)
  • scenarios/simple_bank/src/EventHandlers.ts (0 hunks)
💤 Files with no reviewable changes (48)
  • scenarios/nft-factory/contracts/deployments/fuji/.chainId
  • scenarios/ploffen/contracts/.gitignore
  • scenarios/ploffen/contracts/tasks/index.js
  • scenarios/ploffen/indexer/README.md
  • scenarios/simple_bank/contracts/tasks/index.js
  • scenarios/ploffen/contracts/package.json
  • scenarios/simple_bank/contracts/.gitignore
  • scenarios/ploffen/contracts/contracts/GameToken.sol
  • scenarios/nft-factory/contracts/.gitignore
  • scenarios/ploffen/contracts/README.md
  • scenarios/simple_bank/contracts/hardhat.config.js
  • scenarios/simple_bank/config.yaml
  • scenarios/nft-factory/config.yaml
  • scenarios/nft-factory/contracts/contracts/NftFactory.sol
  • scenarios/nft-factory/contracts/tasks/mintSimpleNftTask.js
  • scenarios/nft-factory/schema.graphql
  • scenarios/nft-factory/contracts/tasks/index.js
  • scenarios/ploffen/contracts/tasks/winPloffenTask.js
  • scenarios/nft-factory/contracts/tasks/newSimpleNftTask.js
  • scenarios/ploffen/indexer/config.yaml
  • scenarios/simple_bank/contracts/tasks/makeDepositTask.js
  • scenarios/nft-factory/contracts/package.json
  • scenarios/simple_bank/contracts/package.json
  • scenarios/ploffen/contracts/hardhat.config.js
  • scenarios/nft-factory/README.md
  • scenarios/nft-factory/contracts/deploy/deploy.js
  • scenarios/nft-factory/src/EventHandlers.ts
  • scenarios/ploffen/contracts/tasks/playPloffenTask.js
  • scenarios/simple_bank/schema.graphql
  • scenarios/nft-factory/contracts/README.md
  • scenarios/nft-factory/config.fuji.yaml
  • scenarios/simple_bank/contracts/deploy/deploy.js
  • scenarios/nft-factory/abis/NftFactory.json
  • scenarios/simple_bank/contracts/tasks/newAccountTask.js
  • scenarios/simple_bank/contracts/abis/SimpleBank.json
  • scenarios/simple_bank/contracts/tasks/makeWithdrawalTask.js
  • scenarios/ploffen/indexer/schema.graphql
  • scenarios/ploffen/contracts/abis/Ploffen.json
  • scenarios/ploffen/contracts/contracts/Ploffen.sol
  • scenarios/nft-factory/contracts/contracts/SimpleNft.sol
  • scenarios/simple_bank/contracts/contracts/SimpleBank.sol
  • scenarios/ploffen/contracts/abis/IERC20.json
  • scenarios/simple_bank/README.md
  • scenarios/simple_bank/src/EventHandlers.ts
  • scenarios/ploffen/contracts/deploy/deploy.js
  • scenarios/nft-factory/abis/SimpleNft.json
  • scenarios/ploffen/indexer/src/EventHandlers.res
  • scenarios/nft-factory/contracts/deployments/fuji/solcInputs/bf545600cc7f64ad89f68da4537bebcf.json
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@moose-code
moose-code requested a review from DZakh May 20, 2025 08:28
@moose-code

Copy link
Copy Markdown
Member Author

@DZakh I think there is more we can delete too like you mentioned. This is a lot of code just sitting in the repo that is not needed and out of date.

@moose-code

Copy link
Copy Markdown
Member Author

@DZakh If happy I can delete all except the 3 scenarios that you regularly update?

@DZakh DZakh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Did you use codex for this? How is it?

As you said, we use only test_codegen, erc20_multichain_smth, fuel_test projects. There's also one shared with helpers either tests or helpers, I don't remember exactly. I think it's fine to remove the rest.

@DZakh
DZakh merged commit f1b54d1 into main May 20, 2025
@DZakh
DZakh deleted the codex/remove-old-scenarios-ploffen-simple-bank-nft-factory branch May 20, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants