Remove deprecated scenarios - #537
Conversation
WalkthroughThis change removes all files related to three blockchain application scenarios: NFT Factory, Ploffen, and Simple Bank. The deletions encompass smart contract source code, deployment scripts, configuration files, GraphQL schemas, event handler implementations, ABIs, documentation, and supporting package files. No code, configuration, or documentation remains for these scenarios in the repository. Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (48)
💤 Files with no reviewable changes (48)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@DZakh I think there is more we can delete too like you mentioned. This is a lot of code just sitting in the repo that is not needed and out of date. |
|
@DZakh If happy I can delete all except the 3 scenarios that you regularly update? |
DZakh
left a comment
There was a problem hiding this comment.
Nice 👍 Did you use codex for this? How is it?
As you said, we use only test_codegen, erc20_multichain_smth, fuel_test projects. There's also one shared with helpers either tests or helpers, I don't remember exactly. I think it's fine to remove the rest.
Summary
ploffen,simple_bank, andnft-factoryscenariosTesting
cargo test --no-default-features --verbose(fails: Could not connect to server)Summary by CodeRabbit
These changes remove the ability to interact with, deploy, or index data for the affected scenarios.