Move codegen from Config.res file - #59
Conversation
|
Here's the diff of the codegen output.🙌🧠🦜 |
| let empty = () => []->Map.fromArray(~id=module(Chain.ChainIdCmp)) | ||
|
|
There was a problem hiding this comment.
I don't see where this is used...
| }, | ||
| shouldUseHypersyncClientDecoder: true, | ||
| isUnorderedMultichainMode: false, | ||
| chainMap: ChainMap.empty(), |
There was a problem hiding this comment.
Ah I see it's here. Hmmm, I actually don't like that mock is generated here. Since it's only for our internal tests.
There was a problem hiding this comment.
Looking through, I also can't see that this is used.
There was a problem hiding this comment.
It's in Integration_ts_helpers
There was a problem hiding this comment.
Ah I see it's here. Hmmm, I actually don't like that mock is generated here. Since it's only for our internal tests.
I can remove it in the next PR when I clean up ChainMap
JonoPrest
left a comment
JonoPrest
left a comment
There was a problem hiding this comment.
Can we remove the empty function on ChainMap and the unused mock function?
Otherwise I'm happy with the change 👍🏼
Perhaps we should think about have a unified place where we store refs, that need to be set and registered.
2 participants
Ideally:
refand start passing config as an argument once it's codegenedConfig.getConfigusage and use config from argsWhat I'll do next:
ChainMapfrom handlebars and add support for Fuel chains.