Skip to content

Fix insert values logic (entities with array fields) - #614

Merged
DZakh merged 1 commit into
mainfrom
dz/fix-insert-values
Jun 20, 2025
Merged

Fix insert values logic (entities with array fields)#614
DZakh merged 1 commit into
mainfrom
dz/fix-insert-values

Conversation

@DZakh

@DZakh DZakh commented Jun 20, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Refactor
    • Streamlined data chunking and conversion logic for database insert operations, improving efficiency and maintainability.
    • Updated startup script to use the envio CLI for starting processes instead of running a specific JavaScript file directly.

@DZakh
DZakh requested a review from JonoPrest June 20, 2025 14:43
@coderabbitai

coderabbitai Bot commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The updates streamline the chunking and data transformation logic in the PgStorage's setOrThrow function by removing unnecessary intermediate conversions and simplifying how items are chunked for insertion queries. Additionally, the integration test's startup script is changed to use the envio CLI start command instead of running a specific JS file directly.

Changes

File(s) Change Summary
codegenerator/cli/npm/envio/src/PgStorage.res Simplified chunking and data transformation in setOrThrow; removed intermediate payload conversion.
codegenerator/integration_tests/tests/test_indexers/dynamic_contracts/package.json Changed start script to use envio start instead of direct JS file execution.

Poem

In the garden of code where the logic flows free,
Chunking’s now simpler—oh, what a spree!
No more flattening fields, just direct and neat,
With envio start, our tests can compete.
A hop and a skip, the changes are done—
This rabbit approves, now onward we run!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97eb18e and 31224eb.

⛔ Files ignored due to path filters (1)
  • codegenerator/integration_tests/tests/test_indexers/dynamic_contracts/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • codegenerator/cli/npm/envio/src/PgStorage.res (1 hunks)
  • codegenerator/integration_tests/tests/test_indexers/dynamic_contracts/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build_and_test
🔇 Additional comments (5)
codegenerator/integration_tests/tests/test_indexers/dynamic_contracts/package.json (1)

12-12: Good alignment with updated CLI interface.

The change from direct file execution to using envio start correctly leverages the updated CLI functionality, making the startup process more consistent with the tool's intended usage pattern.

codegenerator/cli/npm/envio/src/PgStorage.res (4)

318-318: Improved chunking logic simplifies data flow.

The direct chunking of the items array without pre-flattening eliminates unnecessary intermediate transformations and should improve performance.


322-322: Simplified chunk size comparison is more readable.

The direct comparison chunkSize === maxItemsPerQuery is clearer than the previous logic that involved field count calculations.


329-330: Consistent conversion approach across code paths.

Moving the conversion to query execution time (line 330) and using chunkSize directly for SQL generation (line 329) creates a cleaner separation of concerns between chunking and data transformation.


337-340: UNNEST approach properly aligned with VALUES changes.

The UNNEST code path now consistently applies conversion at query time, maintaining the same pattern as the VALUES approach. This ensures both insertion strategies handle data transformation uniformly.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JonoPrest JonoPrest left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had time to look but let me know if its solved

@DZakh
DZakh merged commit 2244642 into main Jun 20, 2025
@DZakh
DZakh deleted the dz/fix-insert-values branch June 20, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants