Skip to content

Fix source time prom metric - #677

Merged
DZakh merged 2 commits into
mainfrom
dz/fix-source-time-prom-metric
Aug 11, 2025
Merged

Fix source time prom metric#677
DZakh merged 2 commits into
mainfrom
dz/fix-source-time-prom-metric

Conversation

@DZakh

@DZakh DZakh commented Aug 8, 2025

Copy link
Copy Markdown
Member

Used the wrong source 😅

Summary by CodeRabbit

  • New Features
    • No user-facing feature changes in this release.
  • Bug Fixes
    • Corrected status transition metrics to reference the previous state before updating, eliminating misattributed counters during rapid changes. This improves monitoring accuracy, resulting in clearer dashboards and fewer false-positive alerts. No impact on user workflows; changes enhance observability reliability only.

@coderabbitai

coderabbitai Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Adjusted promCounter selection in trackNewStatus to switch on the current sourceManager.status (previous status) rather than the incoming newStatus, then increments the counter, resets statusStart, and updates status to newStatus.

Changes

Cohort / File(s) Summary of changes
Status metric switch logic
codegenerator/cli/npm/envio/src/sources/SourceManager.res
In trackNewStatus, promCounter now switches on sourceManager.status instead of newStatus; then increments metric with chainId, resets statusStart, and sets status to newStatus. No exported signatures changed.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant SourceManager
  participant Prometheus

  Caller->>SourceManager: trackNewStatus(newStatus)
  activate SourceManager
  Note over SourceManager: Select promCounter using previous status (sourceManager.status)
  SourceManager->>Prometheus: promCounter.labels(chainId).inc()
  SourceManager->>SourceManager: statusStart <- now
  SourceManager->>SourceManager: status <- newStatus
  deactivate SourceManager
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

I twitched my nose at metrics’ gate,
A hop back first to mark the state.
One counter nudged, then clocks reset—
Now onward to the freshest set.
With paws on logs and ears alert,
I trace the flow—no hop invert!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7be1c34 and 29c011b.

📒 Files selected for processing (1)
  • codegenerator/cli/npm/envio/src/sources/SourceManager.res (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dz/fix-source-time-prom-metric

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DZakh
DZakh requested a review from JonoPrest August 8, 2025 14:04
@DZakh
DZakh enabled auto-merge (squash) August 11, 2025 08:45
@DZakh
DZakh merged commit 87c1c78 into main Aug 11, 2025
1 of 2 checks passed
@DZakh
DZakh deleted the dz/fix-source-time-prom-metric branch August 11, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants