Skip to content

Use versioned API module and comment out replace - #4596

Merged
mozesl-nokia merged 1 commit into
kptdev:mainfrom
nokia:use-api-module
Jun 18, 2026
Merged

Use versioned API module and comment out replace#4596
mozesl-nokia merged 1 commit into
kptdev:mainfrom
nokia:use-api-module

Conversation

@mozesl-nokia

Copy link
Copy Markdown
Contributor

Now that we have a released API module tag, we can use that and remove the replace directive (kept commented out for convenience).

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Copilot AI review requested due to automatic review settings June 18, 2026 11:22
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 18, 2026
@netlify

netlify Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 0b7b0ee
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a33d4ef21ebdd0008b6598d
😎 Deploy Preview https://deploy-preview-4596--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added area/release kpt release issues go Pull requests that update Go code labels Jun 18, 2026

@liamfallon liamfallon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dosubot dosubot Bot added the lgtm label Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the root Go module to consume the newly tagged github.com/kptdev/kpt/api nested module version, instead of relying on a local replace to ./api, while keeping the replace line commented for convenience.

Changes:

  • Pin github.com/kptdev/kpt/api to v0.0.1 in go.mod (replacing the prior zero pseudo-version).
  • Comment out the local replace github.com/kptdev/kpt/api => ./api directive.
  • Update go.sum to include checksums for github.com/kptdev/kpt/api v0.0.1.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Switches root module to depend on released kpt/api version; comments out the local replace.
go.sum Records checksums for the newly pinned kpt/api module version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
@mozesl-nokia
mozesl-nokia requested review from a team June 18, 2026 11:37
@mozesl-nokia
mozesl-nokia merged commit b1c4617 into kptdev:main Jun 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release kpt release issues go Pull requests that update Go code lgtm size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants