Improve logging of render pipeline execution (part 1) - #4678
Merged
Conversation
mozesl-nokia
added
area/hydrate
area/fn-runtime
mozesl-nokia
requested review from
efiacor,
kispaljr and
liamfallon
as code owners
August 3, 2026 15:26
dosubot
Bot
added
the
size:L
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📄 Knowledge review✏️ Suggested updates2 page suggestions need review.
|
efiacor
approved these changes
Aug 6, 2026
Contributor
|
I guess this, and subsequent changes will require doc and test updates. |
Contributor
Author
|
@efiacor it looks like Dosu did catch at least some of the needed changes (and some that are not), but I don't see a way to accept it's changes... |
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
…in log message Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
…ter formatting back to docs Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com> Assisted-by: Cursor:grok-4.5
mozesl-nokia
force-pushed
the
pkg-display-name
branch
from
August 6, 2026 15:06
b860438 to
2b32161
Compare
|
Contributor
Author
|
Looking through the docs, the current formatting of the logs looked way off compared to the docs, so I matched them back to the docs. |
efiacor
approved these changes
Aug 6, 2026
liamfallon
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main visible change in this PR is that now for every log line in render that starts with
[RUNNING]we also log the package name after it. Also, the ":" in OptPrintf was moved to after the package name. These were supposed to be part of the "port additional changes from Porch" but got lost somewhere in the merges.The bulk of the changes are actually under the hood, preparing for a more in-depth change of the whole printer interface. This is mainly some new custom printer formatting options which can accomodate Porch's naming scheme for subpackages.
Auxiliary changes:
*Update: Looking into the docs revealed that when we merged things from Porch we actually lost a lot of the formatting (newlines, indentation, etc.). I mostly reverted those changes so the formatting now matches what was in the docs. Also updated the docs to contain the "on package..." on the appropriate lines.
AI attribution: