Fix rogue cert directories causing EISDIR on start - #488
Merged
Conversation
❌ Deploy Preview for lando-core failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #486
Docker creates missing bind-mount sources as directories. The v3
landoservice bind-mounts~/.lando/certs/<id>.<project>.crt|keywheneverssl: true, but those files are only generated atpre-start, so if Docker ever touches those mounts while the files are missing it leaves rogue directories behind — and cert generation then dies withEISDIRon every subsequentlando start/rebuild.The first commits add a deterministic repro to the certs leia spec (rogue dirs at the cert paths before
lando start), which failed CI with the exact error from the issue (failing run):Then the fix, in two layers:
utils/write-file.jsnow removes a directory sitting at the target path before writing. Existing files are never removed so bind-mounted files keep their inode across rewrites, preserving the Proxy - error mounting /certs/cert.key #242 WSL fix. Unit tests cover both behaviors.builders/_lando.jsensures the cert paths exist as (possibly empty) files before they are ever bind-mounted, so Docker can no longer fabricate directories there in the first place.