Add real-emulator e2e tests for snapshot load --merge strategies - #397
Merged
Conversation
Covers overwrite, account-region-merge, and service-merge against a real LocalStack container instead of the mocked emulator the existing snapshot tests use, which never exercised the actual merge round-trip (DEVX-946). Pinned to the "dev" image tag since the service-merge fix isn't in a "latest" release yet.
peter-smith-phd
added
docs: skip
peter-smith-phd
marked this pull request as ready for review
July 20, 2026 22:03
anisaoshafi
approved these changes
Jul 21, 2026
anisaoshafi
left a comment
anisaoshafi
left a comment
Collaborator
There was a problem hiding this comment.
Quite useful 💯, thanks for the comprehensive test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a real end-to-end test for
lstk snapshot load --merge=overwrite|account-region-merge|service-mergeagainst a real LocalStack container — the existing snapshot load tests only exercise a mocked emulator and never touch the actual merge round-trip.Builds two snapshots files containing slightly-overlapping content. The test loads the first snapshot, merges in the second snapshot (using the three different strategies), then validates the output.
lstk aws,lstk save,lstk load --merge=<strategy>are all used, just as the user would use them.Closes DEVX-946.