[Editorial review] BiDi - Add pages for navigation and page load events of browsingContext module - #44571
Conversation
juliandescottes
left a comment
There was a problem hiding this comment.
(answers for the inline questions, reviewing the rest of the PR still, thanks!)
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks, just some comments on my end, will take another look once they are addressed.
|
Thanks a lot for the review, @juliandescottes! Let me know what you think and if any more updates are needed. Thanks! |
|
Thanks @juliandescottes for checking. @pepelsbey, sending to you now for an editorial review. |
juliandescottes
left a comment
There was a problem hiding this comment.
Thanks @dipikabh !
Some additional comments, but I think this is good to go!
pepelsbey
left a comment
There was a problem hiding this comment.
Looks good! Thank you 🙂
A few suggestions below.
|
Thanks for the review, Vadim! |
Description
This PR adds pages for the following navigation and page load events:
browsingContext.navigationStartedbrowsingContext.navigationCommittedbrowsingContext.domContentLoadedbrowsingContext.loadbrowsingContext.navigationFailedbrowsingContext.fragmentNavigatedbrowsingContext.historyUpdatedNote
browsingContext.navigationAbortedis not documented yet. The BCD key is also missing for this event. I'll cover it when there is an implementation.Spec links
Related issue
Doc issue: mdn/mdn#851