Slightly improve missing property errors - #28298
Merged
Wesley Wigham (weswigham) merged 8 commits intoNov 12, 2018
Merged
Conversation
Member
Author
|
cc Daniel Rosenwasser (@DanielRosenwasser) who should look over the copy and decide if he likes it~ |
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Nov 1, 2018
Member
Author
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Nov 6, 2018
| ~~ | ||
| !!! error TS2322: Type 'A' is not assignable to type 'B'. | ||
| !!! error TS2322: Property 'b' is missing in type 'A'. | ||
| !!! error TS2737: Property 'b' is missing in type 'A' but present in type 'B'. |
There was a problem hiding this comment.
Part of me feels like we lose some context on why we're reporting the error message when it's the first elaboration.
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Nov 6, 2018
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Nov 12, 2018
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Daniel Rosenwasser (DanielRosenwasser)
left a comment
Member
There was a problem hiding this comment.
Looks good but I filed #28491 as a follow-up.
Wesley Wigham (weswigham)
deleted the
better-missing-properties-error
branch
November 12, 2018 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26423
Removes a layer from missing property errors that aren't excess property errors and lists multiple properties when multiple properties are missing, up to a limit.