Port #48978 forward to the revised FAR code - #49267
Merged
Merged
Conversation
The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.
Andrew Casey (amcasey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Sheetal Nandi (sheetalkamat)
May 26, 2022 20:11
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Member
Author
Andrew Casey (amcasey)
force-pushed
the
GH48978Redux
branch
from
May 27, 2022 16:18
30bb76d to
8ab012d
Compare
Sheetal Nandi (sheetalkamat)
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old regression test didn't catch the corresponding bug in the new code because it hit the fast path where there's only a single project.