Skip to content

Fix issue #5444 - #5566

Merged
Daniel Rosenwasser (DanielRosenwasser) merged 3 commits into
microsoft:masterfrom
jeffreymorlan:fix5444
Nov 28, 2015
Merged

Fix issue #5444#5566
Daniel Rosenwasser (DanielRosenwasser) merged 3 commits into
microsoft:masterfrom
jeffreymorlan:fix5444

Conversation

@jeffreymorlan

Copy link
Copy Markdown
Contributor

reportImplementationExpectedError: The next node in the tree is not
necessarily consecutive. This happens due to syntax errors, e.g.

class C { foo(), foo(); }

Edit by Daniel Rosenwasser (@DanielRosenwasser): Fixes #5444

reportImplementationExpectedError: The next node in the tree is not
necessarily consecutive. This happens due to syntax errors, e.g.

    class C { foo(), foo(); }
@msftclas

Hi jeffreymorlan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy

Copy link
Copy Markdown
Contributor

Can you please add unit tests.

@DanielRosenwasser

Copy link
Copy Markdown
Member

To be clear, Mohamed Hegazy (@mhegazy) does't mean a unit test, he means an end-to-end test. Check out Adding a Test in our CONTRIBUTING.md.

Comment thread src/compiler/checker.ts Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that you need this test because garbage declarations may be introduced between overloads and cause issues according to our expectations

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@DanielRosenwasser

Copy link
Copy Markdown
Member

👍 Vladimir Matveev (@vladima) could you take a look?

@vladima

Copy link
Copy Markdown
Contributor

👍 after Daniel Rosenwasser (@DanielRosenwasser) note about the comment is addressed

@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 2f282a7 into microsoft:master Nov 28, 2015
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants