fix: correct ArrayQueue boundaries in takeWhile and takeFromEndWhile

[Sangeet (Muszic)]

This PR fixes two symmetrical boundary bugs in ArrayQueue where takeWhile and takeFromEndWhile would ignore the internal lastIdx and firstIdx pointers. If both methods were interleaved on the same queue instance, it would lead to out-of-bounds reading and queue state corruption.

Fixes:

• takeWhile now correctly checks startIdx <= this.lastIdx (previously checked against this.items.length).
• takeFromEndWhile now correctly checks endIdx >= this.firstIdx (previously checked >= 0).

Tests:
Added regression tests to arrays.test.ts to ensure that mixed calls to takeWhile and takeFromEndWhile safely respect the active boundaries of the queue. Also includes the updated monaco.d.ts generated by the watch task.

[Sangeet (Muszic)]

Review the PR please João Moreno (@joaomoreno)

[João Moreno (joaomoreno)]

Sangeet (@Muszic) Did you review it yourself? What's up with those monaco.d.ts changes? Please remove them.

[Sangeet (Muszic)]

João Moreno (@joaomoreno) Apologies for that! The local watch task generated those diffs while I was compiling the test runner, and I mistakenly lumped them into the commit.

I have removed the monaco.d.ts changes and updated the branch. The PR is now strictly scoped to the ArrayQueue logic fix and the regression tests. Thanks for catching that!

[Sangeet (Muszic)]

Review the PR please João Moreno (@joaomoreno)

[João Moreno (joaomoreno)]

Moving it to Henning Dieterichs (@hediet)

[Sangeet (Muszic)]

Review the PR please Henning Dieterichs (@hediet)

[Sangeet (Muszic)]

Review the PR please Henning Dieterichs (@hediet)

[Sangeet (Muszic)]

Review the PR please Henning Dieterichs (@hediet)

[Sangeet (Muszic)]

Review the PR please Henning Dieterichs (@hediet)

[Sangeet (Muszic)]

Henning Dieterichs (@hediet) I updated the branch and triggered a rebuild to clear out those flaky infrastructure failures (OOM and GPU crash). Whenever you have a moment, could you approve the workflows to run again? Thank you!

[Sangeet (Muszic)]

Ulugbek Abdullaev (@ulugbekna) Henning Dieterichs (@hediet) Thank you both for the reviews and approvals!

Since I am an outside contributor, the CI is currently paused. Could one of you please trigger the workflows when you get a chance so the auto-merge can finish up? Thank you!

[Sangeet (Muszic)]

Henning Dieterichs (@hediet) Ulugbek Abdullaev (@ulugbekna) Thank you both again for the approvals!

The CI is currently failing on the Linux runners, but the errors appear to be completely unrelated infrastructure/main branch issues rather than the ArrayQueue changes. Specifically:

Browser: Playwright is throwing HTTP 404s for vsda_bg.wasm.

Remote: The headless GPU process is crashing 6 times on initialization.

Since the core logic changes have been approved, could one of you kindly force-merge this, or trigger a re-run if those main branch issues have been patched? Thank you!

[Sangeet (Muszic)]

Henning Dieterichs (@hediet) Ulugbek Abdullaev (@ulugbekna) Can you please trigger a re-run or force merge

[Sangeet (Muszic)]

João Moreno (@joaomoreno) Henning Dieterichs (@hediet) Ulugbek Abdullaev (@ulugbekna) Megan Rogge (@meganrogge) Any update guys on merging this PR

[Sangeet (Muszic)]

Can you please run the workflows and merge Henning Dieterichs (@hediet)

[Sangeet (Muszic)]

Can you please run the workflows and merge Henning Dieterichs (@hediet) Ulugbek Abdullaev (@ulugbekna)

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes a bug in ArrayQueue.takeWhile and takeFromEndWhile where the loop bounds used the underlying array's full range instead of respecting the queue's current firstIdx/lastIdx window. This caused incorrect results when both methods were used on the same queue.

Changes:

• Use this.lastIdx as the upper bound in takeWhile instead of this.items.length.
• Use this.firstIdx as the lower bound in takeFromEndWhile instead of 0.
• Add a mixed-usage test covering both orderings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/vs/base/common/arrays.ts	Constrain loop iteration to the active queue window in both take methods.
src/vs/base/test/common/arrays.test.ts	Adds a test verifying correct behavior when takeWhile and takeFromEndWhile are mixed.

[Sangeet (Muszic)]

merge the PR please Henning Dieterichs (@hediet)