Add retry support for HTTP execution failure - #1702
Merged
balamurugana merged 2 commits intoMay 14, 2026
Merged
Conversation
balamurugana
marked this pull request as draft
May 11, 2026 15:13
balamurugana
force-pushed
the
Add-retry-support-for-HTTP-execution-failure
branch
8 times, most recently
from
May 12, 2026 08:11
5475995 to
81ad96c
Compare
…cts() cleanup (minio#1700)" This reverts commit 63242f0.
balamurugana
force-pushed
the
Add-retry-support-for-HTTP-execution-failure
branch
from
May 12, 2026 08:25
81ad96c to
9e8f51f
Compare
balamurugana
marked this pull request as ready for review
May 12, 2026 08:25
shtripat
reviewed
May 12, 2026
allanrogerr
reviewed
May 12, 2026
allanrogerr
left a comment
allanrogerr
left a comment
Contributor
There was a problem hiding this comment.
The new retry logic including interceptor, setRetry replacement logic, body-replay across retries, NPE-safe trace formatting are not unit-tested. The functional tests cover a happy path, but
- no test creates a scenario to verify retry actually fires,
- no test verifies the maxRetries boundary,
- no test checks setRetry replaces the interceptor correctly,
- no test exercises a malformed request.method()
Could you have Claude generate some tests please?
allanrogerr
reviewed
May 12, 2026
allanrogerr
left a comment
allanrogerr
left a comment
Contributor
There was a problem hiding this comment.
Additional comments @balamurugana PTAL
balamurugana
force-pushed
the
Add-retry-support-for-HTTP-execution-failure
branch
3 times, most recently
from
May 13, 2026 02:41
6afbeba to
9b53fa8
Compare
Contributor
|
Rechecking |
allanrogerr
reviewed
May 13, 2026
Contributor
|
Just a couple missing tests if you dont mind and an NPE guard. Thank you for this solution @balamurugana ! |
Signed-off-by: Bala.FA <bala@minio.io>
balamurugana
force-pushed
the
Add-retry-support-for-HTTP-execution-failure
branch
from
May 13, 2026 13:24
9b53fa8 to
248990b
Compare
Member
Author
@allanrogerr Updated the PR. Thanks! |
allanrogerr
approved these changes
May 14, 2026
Contributor
|
@shtripat @rraulinio PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.