llbsolver: keep session for context calls - #729
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This was referenced Nov 20, 2018
AkihiroSuda
approved these changes
Nov 20, 2018
This was referenced Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The op methods set session from vertex to the context before calling but it was missing for the one-off calls in vertex context. Most notably
ResolveImageConfigis called this way, meaning that when called to the gateway frontend the session was lost and authentication didn't work for that call.Reported in #720 (comment)
Note that fix actually disables a workaround for grc.io authentication because a side effect of this bug caused manifest and blob pulls happen together.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com